diff options
| author | Werner Koch <[email protected]> | 2013-09-16 13:57:01 +0000 |
|---|---|---|
| committer | Werner Koch <[email protected]> | 2013-09-16 13:57:01 +0000 |
| commit | 9dc6dd0572102a2fa27df28ba4d66728827eb03d (patch) | |
| tree | dbba3ee3e3e94444d0f501eb58e6d48a208a7cce | |
| parent | mpicalc: Change copyright notice. (diff) | |
| download | gnupg-9dc6dd0572102a2fa27df28ba4d66728827eb03d.tar.gz gnupg-9dc6dd0572102a2fa27df28ba4d66728827eb03d.zip | |
Fix bug in mpi_tdiv_q_2exp.
* mpi/mpi-internal.h (MPN_COPY_INCR): Make it work.
--
This bug has been with us since the version 0.0.0 of GnuPG.
Fortunately it only affects an optimized code path which is rarely
used in practice: If the shift size matches the size of a
limb (i.e.. 32 or 64); this is is_prime in primegen.c. Over there the
Rabin-Miller test may fail with a probability of 2^-31 (that is if the
to be tested prime - 1 has the low 32 bits cleared). In practice the
probability is even much less because we first do a Fermat test on the
randomly generated candidates which sorts out the majority of
composite numbers.
The bug in MPN_COPY_INCR was found by Sven Bjorn.
Signed-off-by: Werner Koch <[email protected]>
(back ported from Libgcrypt
commit 7f7a5ef59962ae1a819b5060f9b781469bfe27d5)
| -rw-r--r-- | mpi/mpi-internal.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/mpi/mpi-internal.h b/mpi/mpi-internal.h index c1df30ad8..46da08d0d 100644 --- a/mpi/mpi-internal.h +++ b/mpi/mpi-internal.h @@ -104,7 +104,7 @@ typedef int mpi_size_t; /* (must be a signed type) */ do { \ mpi_size_t _i; \ for( _i = 0; _i < (n); _i++ ) \ - (d)[_i] = (d)[_i]; \ + (d)[_i] = (s)[_i]; \ } while (0) #define MPN_COPY_DECR( d, s, n ) \ |