aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorWerner Koch <[email protected]>2022-06-14 09:33:27 +0000
committerWerner Koch <[email protected]>2022-06-14 09:39:31 +0000
commit7b1db7192e6e4d0cfc439b23b13831837c85bc21 (patch)
tree37c98aa50a072eab5c625afcbb0e7cc3664e0fa7
parentagent,scd: Make sure to set CONFIDENTIAL flag in Assuan. (diff)
downloadgnupg-7b1db7192e6e4d0cfc439b23b13831837c85bc21.tar.gz
gnupg-7b1db7192e6e4d0cfc439b23b13831837c85bc21.zip
g10: Fix garbled status messages in NOTATION_DATA
* g10/cpr.c (write_status_text_and_buffer): Fix off-by-one -- Depending on the escaping and line wrapping the computed remaining buffer length could be wrong. Fixed by always using a break to terminate the escape detection loop. Might have happened for all status lines which may wrap. GnuPG-bug-id: T6027
-rw-r--r--g10/cpr.c13
1 files changed, 4 insertions, 9 deletions
diff --git a/g10/cpr.c b/g10/cpr.c
index d502e8b52..bc4b715ed 100644
--- a/g10/cpr.c
+++ b/g10/cpr.c
@@ -328,20 +328,15 @@ write_status_text_and_buffer (int no, const char *string,
}
first = 0;
}
- for (esc=0, s=buffer, n=len; n && !esc; s++, n--)
+ for (esc=0, s=buffer, n=len; n; s++, n--)
{
if (*s == '%' || *(const byte*)s <= lower_limit
|| *(const byte*)s == 127 )
esc = 1;
if (wrap && ++count > wrap)
- {
- dowrap=1;
- break;
- }
- }
- if (esc)
- {
- s--; n++;
+ dowrap=1;
+ if (esc || dowrap)
+ break;
}
if (s != buffer)
es_fwrite (buffer, s-buffer, 1, statusfp);