aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorWerner Koch <[email protected]>2025-07-24 08:37:24 +0000
committerWerner Koch <[email protected]>2025-07-24 08:37:24 +0000
commit1c5a2b963b39f99379fe3f53607f103d44b1845a (patch)
tree51a5df87accfaded004fba8e7e16a465f6b331c5
parentgpg: Start using macros for the signature classes. (diff)
downloadgnupg-1c5a2b963b39f99379fe3f53607f103d44b1845a.tar.gz
gnupg-1c5a2b963b39f99379fe3f53607f103d44b1845a.zip
gpg: Use the new constants in one function.
* g10/sign.c (make_keysig_packet): Use signature class constants. -- Having macros for the signature classes should make the code easier to understand for newbies.
-rw-r--r--g10/sign.c15
1 files changed, 10 insertions, 5 deletions
diff --git a/g10/sign.c b/g10/sign.c
index 399d5d76d..413a6025d 100644
--- a/g10/sign.c
+++ b/g10/sign.c
@@ -1814,9 +1814,13 @@ make_keysig_packet (ctrl_t ctrl,
u32 pk_keyid[2], pksk_keyid[2];
unsigned int signhints;
- log_assert ((sigclass >= 0x10 && sigclass <= 0x13) || sigclass == 0x1F
- || sigclass == 0x20 || sigclass == 0x18 || sigclass == 0x19
- || sigclass == 0x30 || sigclass == 0x28 );
+ log_assert ((sigclass&~3) == SIGCLASS_CERT
+ || sigclass == SIGCLASS_KEY
+ || sigclass == SIGCLASS_KEYREV
+ || sigclass == SIGCLASS_SUBKEY
+ || sigclass == SIGCLASS_BACKSIG
+ || sigclass == SIGCLASS_CERTREV
+ || sigclass == SIGCLASS_SUBREV );
if (pksk->version >= 5)
sigversion = 5;
@@ -1853,14 +1857,15 @@ make_keysig_packet (ctrl_t ctrl,
/* Hash the public key certificate. */
hash_public_key (md, pk);
- if (sigclass == 0x18 || sigclass == 0x19 || sigclass == 0x28)
+ if (sigclass == SIGCLASS_SUBKEY || sigclass == SIGCLASS_BACKSIG
+ || sigclass == SIGCLASS_SUBREV)
{
/* Hash the subkey binding/backsig/revocation. */
hash_public_key (md, subpk);
if ((subpk->pubkey_usage & PUBKEY_USAGE_RENC))
signhints |= SIGNHINT_ADSK;
}
- else if (sigclass != 0x1F && sigclass != 0x20)
+ else if (sigclass != SIGCLASS_KEY && sigclass != SIGCLASS_KEYREV)
{
/* Hash the user id. */
hash_uid (md, sigversion, uid);