aboutsummaryrefslogtreecommitdiffstats
path: root/tests/parser/textTest.cpp (unfollow)
Commit message (Collapse)AuthorFilesLines
2024-06-11Fix a test failure in testNewFromString (#311)Jan Engelhardt1-1/+1
Fixes an oversight in d296c2d1.
2024-05-21vmime: prevent loss of a space during text::createFromString (#306)Jan Engelhardt1-5/+5
``` mailbox(text("Test München West", charsets::UTF_8), "[email protected]").generate(); ``` produces ``` =?us-ascii?Q?Test_?= =?utf-8?Q?M=C3=BCnchen?= =?us-ascii?Q?West?= <[email protected]> ``` The first space between ``Test`` and ``München`` is encoded as an underscore along with the first word: ``Test_``. The second space between ``München`` and ``West`` is encoded with neither of the two words and thus lost. Decoding the text results in ``Test MünchenWest`` instead of ``Test München West``. This is caused by how ``vmime::text::createFromString()`` handles transitions between 7-bit and 8-bit words: If an 8-bit word follows a 7-bit word, a space is appended to the previous word. The opposite case of a 7-bit word following an 8-bit word *misses* this behaviour. When one fixes this problem, a follow-up issue appears: ``text::createFromString("a b\xFFc d")`` tokenizes the input into ``m_words={word("a "), word("b\xFFc ", utf8), word("d")}``. This "right-side alignment" nature of the whitespace is a problem for word::generate(): As per RFC 2047, spaces between adjacent encoded words are just separators but not meant to be displayed. A space between an encoded word and a regular ASCII text is not just a separator but also meant to be displayed. When word::generate() outputs the b-word, it would have to strip one space, but only when there is a transition from encoded-word to unencoded word. word::generate() does not know whether d will be encoded or unencoded. The idea now is that we could change the tokenization of ``text::createFromString`` such that whitespace is at the *start* of words rather than at the end. With that, word::generate() need not know anything about the next word, but rather only the *previous* one. Thus, in this patch, 1. The tokenization of ``text::createFromString`` is changed to left-align spaces and the function is fixed to account for the missing space on transition. 2. ``word::generate`` learns how to steal a space character. 3. Testcases are adjusted to account for the shifted position of the space. Fixes: #283, #284 Co-authored-by: Vincent Richard <[email protected]>
2024-05-21tests: switch a byte sequence in textTest (#305)Jan Engelhardt1-2/+2
Switch out the byte sequence by one that is simiarly random, but one which happens to decode as valid UTF-8, such that the expected and actual strings are shown with reasonable characters on a terminal.
2024-05-21Fixes/comments for guessBestEncoding (#304)Jan Engelhardt1-0/+12
* tests: add case for getRecommendedEncoding * vmime: avoid integer multiply wraparound in wordEncoder::guessBestEncoding If the input string is 42949673 characters long or larger, there will be integer overflow on 32-bit platforms when multiplying by 100. Switch that one computation to floating point. * vmime: update comment in wordEncoder::guessBestEncoding
2020-06-16#238 Fixed whitespace between encoded wordsvincent-richard1-0/+85
2018-09-05Code style and clarity.Vincent Richard1-159/+268
2017-01-02Always ignore newlines between words.Vincent Richard1-0/+4
2016-11-05Fixed #149: don't loose charset when fixing invalid broken words.Vincent Richard1-13/+66
2015-02-16Issue #103: fix badly encoded words.Vincent Richard1-0/+46
2015-01-14Fixed issue #98: support for wrongly padded B64 words.Vincent Richard1-0/+22
2014-06-30Added support for language specification in RFC-2047 encoded words and ↵Vincent Richard1-1/+10
RFC-2231 parameter values.
2014-01-15Do not make calls to setlocale() in a library. Use default user locale in ↵Vincent Richard1-0/+24
tests and examples.
2013-11-21Boost/C++11 shared pointers.Vincent Richard1-10/+10
2013-03-08Refactored unit tests.Vincent Richard1-5/+1
2013-02-25Fixed typo in function name.Vincent Richard1-3/+3
2013-02-24Message generation/parsing context. Charset conversion options. Preliminary ↵Vincent Richard1-3/+76
implementation of RFC-6532.
2013-01-10Updated copyright year and maintainer email address.Vincent Richard1-1/+1
2011-06-26Fixed encoding of whitespace. Fixed old test case.Vincent Richard1-1/+41
2011-01-21Fixed possible infinite loop (thanks to John van der Kamp, Zarafa).Vincent Richard1-0/+11
2010-10-18Fold non-encoded lines in the case there is no whitespace in them.Vincent Richard1-0/+14
2010-10-12Fixed missing whitespace in text parsing.Vincent Richard1-2/+52
2010-10-12Encode quotation marks in QP/RFC-2047.Vincent Richard1-0/+8
2010-05-21Always encode special charsets.Vincent Richard1-1/+32
2009-09-06Relicensed VMime under the GNU GPL version 3. Changed copyright year to 2009.Vincent Richard1-2/+2
2008-04-28Fixed extra space in subject (see ↵Vincent Richard1-9/+43
https://sourceforge.net/forum/message.php?msg_id=4894970).
2008-01-04Changed copyright year to 2008.Vincent Richard1-1/+1
2007-11-20Fixed incorrect white-space between words.Vincent Richard1-0/+26
2007-01-01Changed copyright year to 2007.Vincent Richard1-1/+1
2006-10-02Fixed bug #1096610: non-integral number of chars in RFC-2047 encoded words.Vincent Richard1-10/+35
2006-02-05Changed copyright year to 2006.Vincent Richard1-1/+1
2005-09-17Updated FSF address.Vincent Richard1-3/+7
2005-08-25Moved to CppUnit for unit tests framework.Vincent Richard1-196/+179
2005-08-22Added test case for '?' in the middle of the encoded buffer.Vincent Richard1-0/+4
2005-07-12Reference counting and smart pointers.Vincent Richard1-4/+4
2005-06-13Fixed a bug in word parsing.Vincent Richard1-0/+6
2005-03-18Updated VMime website URL.Vincent Richard1-1/+1
2005-03-15More unit tests for 'text' class.Vincent Richard1-3/+103
2005-03-14Added test for linear-white-space between encoded words.Vincent Richard1-0/+26
2005-01-03Changed year to 2005 in copyright header.Vincent Richard1-1/+1
2004-12-30Autotools and libtool support.Vincent Richard1-1/+1
2004-12-26Moved all header files to 'vmime/' directory.Vincent Richard1-3/+3
2004-12-18Default platform handlers (currently only POSIX).Vincent Richard1-2/+2
2004-11-07Moved encodeAndFold() and decodeAndUnfold() functions from "base.cpp" to ↵Vincent Richard1-0/+2
"text.cpp".
2004-11-06New build system for unit tests.Vincent Richard1-0/+133