From 6de3493c92cdf8a90943c4e5e32c60d17c5b6192 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Urs=20F=C3=A4ssler?= <urs.fassler@bbv.ch>
Date: Mon, 26 Oct 2015 16:31:51 +0100
Subject: [PATCH] cleanup compiler errors/warnings

---
 SMTPEmail.pro      |  2 --
 src/smtpclient.cpp | 14 +++++++-------
 src/smtpclient.h   |  4 ++--
 3 files changed, 9 insertions(+), 11 deletions(-)

diff --git a/SMTPEmail.pro b/SMTPEmail.pro
index 4fc4400..02a7d8e 100644
--- a/SMTPEmail.pro
+++ b/SMTPEmail.pro
@@ -16,8 +16,6 @@ TEMPLATE = lib
 DEFINES += SMTP_BUILD
 win32:CONFIG += dll
 
-QMAKE_CXXFLAGS += -fPIC
-
 SOURCES += \
     src/emailaddress.cpp \
     src/mimeattachment.cpp \
diff --git a/src/smtpclient.cpp b/src/smtpclient.cpp
index e7876c8..7370a78 100644
--- a/src/smtpclient.cpp
+++ b/src/smtpclient.cpp
@@ -25,12 +25,12 @@
 /* [1] Constructors and destructors */
 
 SmtpClient::SmtpClient(const QString & host, int port, ConnectionType connectionType) :
+    socket(NULL),
     name("localhost"),
     authMethod(AuthPlain),
     connectionTimeout(5000),
     responseTimeout(5000),
-    sendMessageTimeout(60000),
-    socket(NULL)
+    sendMessageTimeout(60000)
 {
     setConnectionType(connectionType);
 
@@ -332,7 +332,7 @@ bool SmtpClient::login(const QString &user, const QString &password, AuthMethod
             }
         }
     }
-    catch (ResponseTimeoutException e)
+    catch (ResponseTimeoutException)
     {
         // Responce Timeout exceeded
         emit smtpError(AuthenticationFailedError);
@@ -428,7 +428,7 @@ void SmtpClient::quit()
 
 /* [4] Protected methods */
 
-void SmtpClient::waitForResponse() throw (ResponseTimeoutException)
+void SmtpClient::waitForResponse()
 {
     do {
         if (!socket->waitForReadyRead(responseTimeout))
@@ -455,7 +455,7 @@ void SmtpClient::waitForResponse() throw (ResponseTimeoutException)
     } while (true);
 }
 
-void SmtpClient::sendMessage(const QString &text) throw (SendMessageTimeoutException)
+void SmtpClient::sendMessage(const QString &text)
 {
     socket->write(text.toUtf8() + "\r\n");
     if (! socket->waitForBytesWritten(sendMessageTimeout))
@@ -470,11 +470,11 @@ void SmtpClient::sendMessage(const QString &text) throw (SendMessageTimeoutExcep
 
 /* [5] Slots for the socket's signals */
 
-void SmtpClient::socketStateChanged(QAbstractSocket::SocketState state)
+void SmtpClient::socketStateChanged(QAbstractSocket::SocketState /*state*/)
 {
 }
 
-void SmtpClient::socketError(QAbstractSocket::SocketError socketError)
+void SmtpClient::socketError(QAbstractSocket::SocketError /*socketError*/)
 {
 }
 
diff --git a/src/smtpclient.h b/src/smtpclient.h
index f734aad..26afe81 100644
--- a/src/smtpclient.h
+++ b/src/smtpclient.h
@@ -154,9 +154,9 @@ protected:
 
     /* [5] Protected methods */
 
-    void waitForResponse() throw (ResponseTimeoutException);
+    void waitForResponse();
 
-    void sendMessage(const QString &text) throw (SendMessageTimeoutException);
+    void sendMessage(const QString &text);
 
     /* [5] --- */