aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/spi/spi-xilinx.c
Commit message (Collapse)AuthorAgeFilesLines
...
| * | spi/xilinx: Simplify irq allocationMichal Simek2013-07-151-13/+16
| | | | | | | | | | | | | | | | | | | | | | | | Use devm_request_irq() for irq allocation which simplify driver code. Signed-off-by: Michal Simek <[email protected]> Signed-off-by: Mark Brown <[email protected]>
| * | spi/xilinx: Use of_property_read_u32 for reading value from nodeMichal Simek2013-07-151-11/+3
| | | | | | | | | | | | | | | | | | | | | It simplifies driver probing. Signed-off-by: Michal Simek <[email protected]> Signed-off-by: Mark Brown <[email protected]>
| * | spi/xilinx: Clean ioremap callingMichal Simek2013-07-151-9/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | devm_ioremap_resource() automatically checks that struct resource is initialized. Also group platform_get_resource() and devm_ioremap_resource() together. And remove mem resource from struct xilinx_spi. Signed-off-by: Michal Simek <[email protected]> Signed-off-by: Mark Brown <[email protected]>
| * | spi/xilinx: Remove CONFIG_OF from the driverMichal Simek2013-07-151-2/+0
| | | | | | | | | | | | | | | | | | | | | dev.of_node is in struct device all the time. Signed-off-by: Michal Simek <[email protected]> Signed-off-by: Mark Brown <[email protected]>
| * | spi/xilinx: Refer to platform device as pdev in probe() and remove()Mark Brown2013-07-151-16/+17
| | | | | | | | | | | | | | | | | | | | | | | | This is a more traditional name and makes things a bit clearer when referring to actual struct devices as we do frequently during probe(). Signed-off-by: Mark Brown <[email protected]> Acked-by: Michal Simek <[email protected]>
| * | spi/xilinx: Remove remains of of_platform device registrationMark Brown2013-07-151-82/+63
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In the past there used to be a separate platform device type for device tree systems so the probe and removal functions were split into generic and bus sections. Since this is no longer the case simplify the code (and remove some unprototyped exports) by factoring everything into the bus probe() and remove(). Signed-off-by: Mark Brown <[email protected]>
| * | spi/xilinx: Convert to devm_ioremap_resource()Mark Brown2013-07-151-15/+5
| | | | | | | | | | | | | | | | | | Saves code and reduces the possibility of error. Signed-off-by: Mark Brown <[email protected]>
* | | spi/bitbang: Drop empty setup() functionsMark Brown2013-08-091-16/+0
| |/ |/| | | | | | | | | | | Now that the bitbang core does not require a setup() function we can drop the check in the altera, nuc900 and xilinx drivers. Signed-off-by: Mark Brown <[email protected]>
* | spi/xilinx: Revert master->setup function removalMichal Simek2013-07-101-0/+16
|/ | | | | | | | | | | | master->setup() must be initialized to be able to successfully run spi_bitbang_start() and satisfy if/else logic there. "spi: convert drivers to use bits_per_word_mask" (sha1: 24778be20f87d5aadb19624fc768b3159fa43efc) Signed-off-by: Michal Simek <[email protected]> Signed-off-by: Mark Brown <[email protected]>
* Merge remote-tracking branch 'spi/topic/xilinx' into spi-nextMark Brown2013-06-261-9/+21
|\
| * spi: spi-xilinx: Remove redundant platform_set_drvdata()Sachin Kamat2013-06-041-1/+0
| | | | | | | | | | | | | | | | | | Setting platform data to NULL is not necessary. Also fixes the following sparse warning: drivers/spi/spi-xilinx.c:508:35: warning: Using plain integer as NULL pointer Signed-off-by: Sachin Kamat <[email protected]> Signed-off-by: Mark Brown <[email protected]>
| * spi: spi-xilinx: Add run run-time endian detectionMichal Simek2013-06-041-8/+21
| | | | | | | | | | | | | | | | Do not load endian value from platform data and rather autodetect it. Signed-off-by: Michal Simek <[email protected]> Signed-off-by: Mark Brown <[email protected]>
* | Merge remote-tracking branch 'spi/topic/bpw' into spi-nextMark Brown2013-06-261-16/+0
|\ \
| * | spi: convert drivers to use bits_per_word_maskStephen Warren2013-05-291-16/+0
| |/ | | | | | | | | | | | | | | | | | | Fill in the recently added spi_master.bits_per_word_mask field in as many drivers as possible. Make related cleanups, such as removing any redundant error-checking, or empty setup callbacks. Signed-off-by: Stephen Warren <[email protected]> Acked-by: H Hartley Sweeten <[email protected]> Signed-off-by: Mark Brown <[email protected]>
* | spi: spi-xilinx: cleanup a check in xilinx_spi_txrx_bufs()[email protected]2013-06-101-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | '!' has higher precedence than comparisons so the original condition is equivalent to "if (xspi->remaining_bytes == 0)". This makes the static checkers complain. xspi->remaining_bytes is signed and from looking at the code briefly, I think it might be able to go negative. I suspect that going negative may cause a bug, but I don't have the hardware and can't test. Signed-off-by: Dan Carpenter <[email protected]> Signed-off-by: Mark Brown <[email protected]>
* | spi: spi-xilinx: Remove ISR race conditionPeter Crosthwaite2013-06-041-39/+35
|/ | | | | | | | | | | | | | | The ISR currently consumes the rx buffer data and re-enables transmission from within interrupt context. This is bad because if the interrupt occurs again before the ISR exits, the new interrupt will be erroneously cleared by the still completing ISR. Simplified the ISR by just setting the completion variable and exiting with no action. Then just looped the transmit functionality in xilinx_spi_txrx_bufs(). Signed-off-by: Peter Crosthwaite <[email protected]> Signed-off-by: Michal Simek <[email protected]> Signed-off-by: Mark Brown <[email protected]>
* spi: Remove HOTPLUG section attributesGrant Likely2012-12-071-3/+3
| | | | | | | | | | | | | | CONFIG_HOTPLUG is going away as an option. As result the __dev* markings will be going away. Remove use of __devinit, __devexit_p, __devinitdata, __devinitconst, and __devexit. Bill Pemberton has done most of the legwork on this series. I've used his script to purge the attributes from the drivers/gpio tree. Reported-by: Bill Pemberton <[email protected]> Signed-off-by: Grant Likely <[email protected]>
* drivercore: Add helper macro for platform_driver boilerplateGrant Likely2011-10-241-12/+1
| | | | | | | | | | | | | | For simple modules that contain a single platform_driver without any additional setup code then ends up being a block of duplicated boilerplate. This patch adds a new macro, module_platform_driver(), which replaces the module_init()/module_exit() registrations with template functions. Signed-off-by: Grant Likely <[email protected]> Acked-by: Greg Kroah-Hartman <[email protected]> Reviewed-by: Magnus Damm <[email protected]> Reviewed-by: Mark Brown <[email protected]> Reviewed-by: Stephen Boyd <[email protected]>
* spi: reorganize driversGrant Likely2011-06-061-0/+556
Sort the SPI makefile and enforce the naming convention spi_*.c for spi drivers. This change also rolls the contents of atmel_spi.h into the .c file since there is only one user of that particular include file. v2: - Use 'spi-' prefix instead of 'spi_' to match what seems to be be the predominant pattern for subsystem prefixes. - Clean up filenames in Kconfig and header comment blocks Signed-off-by: Grant Likely <[email protected]> Acked-by: Wolfram Sang <[email protected]> Acked-by: Linus Walleij <[email protected]>