aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/rtc/rtc-abx80x.c
Commit message (Collapse)AuthorAgeFilesLines
* rtc: abx80x: Fix WDT bit position of the status registerNobuhiro Iwamatsu2024-11-111-1/+1
| | | | | | | | | | | | The WDT bit in the status register is 5, not 6. This fixes from 6 to 5. Link: https://abracon.com/Support/AppsManuals/Precisiontiming/AB08XX-Application-Manual.pdf Link: https://www.microcrystal.com/fileadmin/Media/Products/RTC/App.Manual/RV-1805-C3_App-Manual.pdf Fixes: 749e36d0a0d7 ("rtc: abx80x: add basic watchdog support") Cc: Jeremy Gebben <[email protected]> Signed-off-by: Nobuhiro Iwamatsu <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Alexandre Belloni <[email protected]>
* rtc: abx80x: Fix return value of nvmem callback on readJoy Chakraborty2024-06-271-4/+8
| | | | | | | | | | | | | | | | | | | | | Read callbacks registered with nvmem core expect 0 to be returned on success and a negative value to be returned on failure. abx80x_nvmem_xfer() on read calls i2c_smbus_read_i2c_block_data() which returns the number of bytes read on success as per its api description, this return value is handled as an error and returned to nvmem even on success. Fix to handle all possible values that would be returned by i2c_smbus_read_i2c_block_data(). Fixes: e90ff8ede777 ("rtc: abx80x: Add nvmem support") Cc: [email protected] Signed-off-by: Joy Chakraborty <[email protected]> Reviewed-by: Dan Carpenter <[email protected]> Reviewed-by: Sean Anderson <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Alexandre Belloni <[email protected]>
* rtc: Explicitly include correct DT includesRob Herring2023-07-271-1/+1
| | | | | | | | | | | | | | | The DT of_device.h and of_platform.h date back to the separate of_platform_bus_type before it as merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also include platform_device.h and of.h. As a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes. Signed-off-by: Rob Herring <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Alexandre Belloni <[email protected]>
* rtc: Switch i2c drivers back to use .probe()Uwe Kleine-König2023-06-061-1/+1
| | | | | | | | | | | | After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new() call-back type"), all drivers being converted to .probe_new() and then 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter") convert back to (the new) .probe() to be able to eventually drop .probe_new() from struct i2c_driver. Signed-off-by: Uwe Kleine-König <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Alexandre Belloni <[email protected]>
* rtc: abx80x: Add nvmem supportSean Anderson2023-02-231-0/+77
| | | | | | | | | | | | | | | | | | | This adds support for the 256-byte internal RAM. There are two windows which can be used to access this RAM: 64 bytes at 0x40 (the "standard" address space) and 128 bytes at 0x80 (the "alternate" address space). We use the standard address space because it is also accessible over SPI (if such a port is ever done). We are limited to 32-byte reads for SMBus compatibility, so there's no advantage to using the alternate address space. There are some reserved bits in the EXTRAM register, and the datasheet doesn't say what to do with them. I've opted to skip a read/modify/write and just write the whole thing. If this driver is ever converted to regmap, this would be a good place to use regmap_update_bits. Signed-off-by: Sean Anderson <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Alexandre Belloni <[email protected]>
* rtc: Include <linux/kstrtox.h> when appropriateChristophe JAILLET2022-11-151-0/+1
| | | | | | | | | | | The kstrto<something>() functions have been moved from kernel.h to kstrtox.h. So, include the latter directly in the appropriate files. Signed-off-by: Christophe JAILLET <[email protected]> Link: https://lore.kernel.org/r/786421fd0435a32206288904a1f879436a717529.1667721637.git.christophe.jaillet@wanadoo.fr Signed-off-by: Alexandre Belloni <[email protected]>
* rtc: abx80x: Convert to .probe_new()Uwe Kleine-König2022-11-151-18/+18
| | | | | | | | | | .probe_new() doesn't get the i2c_device_id * parameter, so determine that explicitly in .probe(). The device_id array has to move up for that to work. Signed-off-by: Uwe Kleine-König <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Alexandre Belloni <[email protected]>
* rtc: abx80x: Add utility function for writing configuration keyKevin P. Fleming2021-02-131-23/+16
| | | | | | | | | | | | | Writing one of key two values into the configuration key register is a common operation, so a utility function has been added to provide consistent behavior and eliminate code duplication. Signed-off-by: Kevin P. Fleming <[email protected]> Cc: Alessandro Zummo <[email protected]> Cc: Alexandre Belloni <[email protected]> To: [email protected] Signed-off-by: Alexandre Belloni <[email protected]> Link: https://lore.kernel.org/r/[email protected]
* rtc: rework rtc_register_device() resource managementBartosz Golaszewski2020-11-191-1/+1
| | | | | | | | | | | | | | | | | | | | rtc_register_device() is a managed interface but it doesn't use devres by itself - instead it marks an rtc_device as "registered" and the devres callback for devm_rtc_allocate_device() takes care of resource release. This doesn't correspond with the design behind devres where managed structures should not be aware of being managed. The correct solution here is to register a separate devres callback for unregistering the device. While at it: rename rtc_register_device() to devm_rtc_register_device() and add it to the list of managed interfaces in devres.rst. This way we can avoid any potential confusion of driver developers who may expect there to exist a corresponding unregister function. Signed-off-by: Bartosz Golaszewski <[email protected]> Signed-off-by: Alexandre Belloni <[email protected]> Link: https://lore.kernel.org/r/[email protected]
* rtc: abx80x: Provide debug feedback for invalid dt propertiesKevin P. Fleming2020-06-051-6/+11
| | | | | | | | | | When the user provides an invalid value for tc-diode or tc-resistor generate a debug message instead of silently ignoring it. Signed-off-by: Kevin P. Fleming <[email protected]> Signed-off-by: Alexandre Belloni <[email protected]> Link: https://lore.kernel.org/r/[email protected]
* rtc: abx80x: Add Device Tree matching tableKevin P. Fleming2020-05-301-0/+49
| | | | | | | | | Enable automatic loading of the module when a Device Tree overlay specifies a device supported by this driver. Signed-off-by: Kevin P. Fleming <[email protected]> Signed-off-by: Alexandre Belloni <[email protected]> Link: https://lore.kernel.org/r/[email protected]
* rtc: abx80x: return meaningful value for RTC_VL_READAlexandre Belloni2019-12-181-5/+2
| | | | | | | | ABX8XX_STATUS_BLF indicates the battery is low and needs to be replaced soon. Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Alexandre Belloni <[email protected]>
* rtc: abx80x: remove useless .removeAlexandre Belloni2019-03-181-6/+0
| | | | | | .remove is empty, remove it. Signed-off-by: Alexandre Belloni <[email protected]>
* rtc: abx80x: use rtc_add_groupAlexandre Belloni2019-03-181-26/+6
| | | | | | | Use rtc_add_group to add the sysfs group in a race free manner. This has the side effect of moving the files to their proper location. Signed-off-by: Alexandre Belloni <[email protected]>
* rtc: abx80x: convert to SPDX identifierAlexandre Belloni2019-03-181-4/+1
| | | | | | Use SPDX-License-Identifier instead of a verbose license text. Signed-off-by: Alexandre Belloni <[email protected]>
* rtc: update my email addressAlexandre Belloni2019-03-041-2/+2
| | | | | | Use my current email address. Signed-off-by: Alexandre Belloni <[email protected]>
* rtc: abx80x: Configure reserved bits in RV1805Marek Vasut2019-01-301-2/+65
| | | | | | | | | | | The RV1805 uses smaller package than the AB1805, discern those two chips based on the compatible value and configure reserved bits in the RV1805 to prevent current leakage and accidental test mode entry. Signed-off-by: Marek Vasut <[email protected]> Cc: Alexandre Belloni <[email protected]> To: [email protected] Signed-off-by: Alexandre Belloni <[email protected]>
* rtc: abx80x: Implement RTC_VL_READ,CLR ioctlsMarek Vasut2018-12-181-0/+38
| | | | | | | | | Implement standard ioctls for polling the battery status and clearing the battery low indication from userspace. Signed-off-by: Marek Vasut <[email protected]> Cc: Alexandre Belloni <[email protected]> Signed-off-by: Alexandre Belloni <[email protected]>
* rtc: abx80x: add basic watchdog supportJeremy Gebben2018-09-121-4/+112
| | | | | | | | | The abx804 and abx805 chips have support for a simple watchdog function that can trigger an external reset. Signed-off-by: Jeremy Gebben <[email protected]> Reviewed-by: Guenter Roeck <[email protected]> Signed-off-by: Alexandre Belloni <[email protected]>
* rtc: abx80x: use a 'priv' struct for client dataJeremy Gebben2018-09-121-8/+19
| | | | | | | | This will allow additional data to be tracked, for future improvements. Signed-off-by: Jeremy Gebben <[email protected]> Signed-off-by: Alexandre Belloni <[email protected]>
* rtc: abx80x: remove useless messageAlexandre Belloni2018-03-021-5/+1
| | | | | | | It is not necessary to print a message when the time is invalid as userspace will already get an error (and an optional dev_dbg message). Signed-off-by: Alexandre Belloni <[email protected]>
* rtc: abx80x: solve race conditionAlexandre Belloni2017-10-121-5/+5
| | | | | | | | There is a race condition that can happen if abx80x_probe() fails after the rtc registration succeeded. Solve that by moving the registration at the end of the probe function. Signed-off-by: Alexandre Belloni <[email protected]>
* rtc: abx80x: switch to rtc_register_deviceAlexandre Belloni2017-10-121-3/+7
| | | | | | This allows for future improvement of the driver. Signed-off-by: Alexandre Belloni <[email protected]>
* rtc: abx80x: use devm_add_action_or_reset()Sudip Mukherjee2016-07-191-7/+5
| | | | | | | | | | If devm_add_action() fails we are explicitly calling the cleanup to free the resources allocated. Lets use the helper devm_add_action_or_reset() and return directly in case of error, as we know that the cleanup function has been already called by the helper if there was any error. Signed-off-by: Sudip Mukherjee <[email protected]> Signed-off-by: Alexandre Belloni <[email protected]>
* rtc: abx80x: handle the oscillator failure bitMylène Josserand2016-03-251-2/+31
| | | | | | | | | | Handle the Oscillator Failure ('OF') bit from Oscillator Status register (0x1D). This bit is cleared on set_time function and is read each time the date/time is read, but only in case of XT Oscillator selection. In RC mode, this bit is always set. Signed-off-by: Mylène Josserand <[email protected]> Signed-off-by: Alexandre Belloni <[email protected]>
* rtc: abx80x: handle autocalibrationMylène Josserand2016-03-251-0/+219
| | | | | | | | | | | | | | | | | | | | | | The autocalibration is separated in two bits to set in Oscillator Control register (0x1c) : - OSEL bit to select the oscillator type (XT or RC). - ACAL bit to select the autocalibration type. These functionnalities are exported in sysfs entries : "oscillator" and "autocalibration". Respectively, the values are "xtal" for XT oscillator and "rc" for RC oscillator and 0 to disable the autocalibration cycle, 512 for a 512 seconds autocalibration cycle and 1024 for a cycle of 1024 seconds. Examples : Set to XT Oscillator echo xtal > /sys/class/rtc/rtc0/device/oscillator Activate an autocalibration every 512 seconds echo 512 > /sys/class/rtc/rtc0/device/autocalibration Signed-off-by: Mylène Josserand <[email protected]> Signed-off-by: Alexandre Belloni <[email protected]>
* rtc: abx80x: add alarm supportAlexandre Belloni2016-01-111-4/+141
| | | | | | Add alarm support to the abx80x driver. Signed-off-by: Alexandre Belloni <[email protected]>
* rtc: abx80x: Add Microcrystal rv1805 supportAlexandre Belloni2016-01-111-0/+1
| | | | | | Microcrystal RV-1805 is compatible with Abracon 1805. Signed-off-by: Alexandre Belloni <[email protected]>
* rtc: abx80x: fix RTC write bitMitja Spes2015-09-051-1/+1
| | | | | | | | Fix RTC write bit as per application manual Cc: [email protected] # 4.1+ Signed-off-by: Mitja Spes <[email protected]> Signed-off-by: Alexandre Belloni <[email protected]>
* rtc: add rtc-abx80x, a driver for the Abracon AB x80x i2c rtcPhilippe De Muyter2015-05-061-0/+307
This is a basic driver for the ultra-low-power Abracon AB x80x series of RTC chips. It supports in particular, the supersets AB0805 and AB1805. It allows reading and writing the time, and enables the supercapacitor/ battery charger. [[email protected]: abx805 depends on i2c] [[email protected]: renam buffer from date to buf in abx80x_rtc_read_time()] Signed-off-by: Philippe De Muyter <[email protected]> Cc: Alessandro Zummo <[email protected]> Signed-off-by: Alexandre Belloni <[email protected]> Signed-off-by: Arnd Bergmann <[email protected]> Cc: Paul Bolle <[email protected]> Cc: Arnd Bergmann <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
generated by cgit (git 2.51.2) at 2025-12-03 10:24:39 +0000