aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/platform/x86/intel_ips.c
Commit message (Collapse)AuthorAgeFilesLines
...
* intel_ips: Print MCP limit exceeded values.Tim Gardner2010-10-051-6/+18
| | | | | | | | | Print some interesting values when MCP limits are exceeded. Signed-off-by: Tim Gardner <[email protected]> Cc: Matthew Garrett <[email protected]> Signed-off-by: Matthew Garrett <[email protected]>
* IPS driver: verify BIOS provided limitsJesse Barnes2010-10-051-0/+23
| | | | | | | | They're optional. If not present or sane, we should use the CPU defaults. Signed-off-by: Jesse Barnes <[email protected]> Signed-off-by: Matthew Garrett <[email protected]>
* IPS driver: don't toggle CPU turbo on unsupported CPUsJesse Barnes2010-10-051-5/+9
| | | | | | | | | If the CPU doesn't support turbo, don't try to enable/disable it. http://bugzilla.kernel.org/show_bug.cgi?id=18742 Signed-off-by: Jesse Barnes <[email protected]> Signed-off-by: Matthew Garrett <[email protected]>
* NULL pointer might be used in ips_monitor()minskey guo2010-10-051-9/+13
| | | | | | | | | | | | The patch is to create ips_adjust thread before ips_monitor begins to run because the latter will kthread_stop() or wake up the former via ips->adjust pointer. Without this change, it is possible that ips->adjust is NULL when kthread_stop() or wake_up_process() is called in ips_monitor(). Signed-off-by: minskey guo <[email protected]> Acked-by: Jesse Barnes <[email protected]> Signed-off-by: Matthew Garrett <[email protected]>
* Release symbol on error-handling path of ips_get_i915_syms()minskey guo2010-10-051-1/+1
| | | | | | | | | In ips_get_i915_syms(), the symbol i915_gpu_busy() is not released when error occurs. Signed-off-by: minskey guo <[email protected]> Acked-by: Jesse Barnes <[email protected]> Signed-off-by: Matthew Garrett <[email protected]>
* old_cpu_power is wrongly divided by 65535 in ips_monitor()minskey guo2010-10-051-1/+1
| | | | | | | | | The variable old_cpu_power is used to save the value of THM_CEC register. In get_cpu_power(), it will be divided by 65535. Signed-off-by: minskey guo <[email protected]> Acked-by: Jesse Barnes <[email protected]> Signed-off-by: Matthew Garrett <[email protected]>
* seqno mask of THM_ITV register is 16bitminskey guo2010-10-051-1/+1
| | | | | | | | | The mask of sequence number in THM_ITV register is 16bit width instead of 8bit. Signed-off-by: minskey guo <[email protected]> Acked-by: Jesse Barnes <[email protected]> Signed-off-by: Matthew Garrett <[email protected]>
* intel_ips: potential null dereferenceDan Carpenter2010-08-161-1/+3
| | | | | | | | | There is a potential NULL dereference of "limits." We can just return NULL earlier to avoid it. The caller already handles NULL returns. Signed-off-by: Dan Carpenter <[email protected]> Reviewed-by: Jesse Barnes <[email protected]> Signed-off-by: Matthew Garrett <[email protected]>
* x86: intel_ips: do not use PCI resources before pci_enable_device()Kulikov Vasiliy2010-08-161-5/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | IRQ and resource[] may not have correct values until after PCI hotplug setup occurs at pci_enable_device() time. The semantic match that finds this problem is as follows: // <smpl> @@ identifier x; identifier request ~= "pci_request.*|pci_resource.*"; @@ ( * x->irq | * x->resource | * request(x, ...) ) ... *pci_enable_device(x) // </smpl> Signed-off-by: Kulikov Vasiliy <[email protected]> Reviewed-by: Jesse Barnes <[email protected]> Signed-off-by: Matthew Garrett <[email protected]>
* ips driver: make it less chattyJesse Barnes2010-08-031-2/+2
| | | | | | | | | We don't need a dev_warn when we exceed a thermal or power limit as we'll handle it appropriately by clamping down on the CPU, GPU or both as needed. Signed-off-by: Jesse Barnes <[email protected]> Signed-off-by: Matthew Garrett <[email protected]>
* X86: intel_ips, check for kzalloc properlyJiri Slaby2010-08-031-4/+5
| | | | | | | | | | | | | | | | | Stanse found that there are two NULL checks missing in ips_monitor. So check their value too and bail out appropriately if the allocation failed. While at it, add one more kfree to the fail path. It is not necessary now, but may be needed in the future when a new allocation is added. And for completeness. Also remove unneeded initialization of the variables. They are all set right after their declaration. Signed-off-by: Jiri Slaby <[email protected]> Signed-off-by: Matthew Garrett <[email protected]> Acked-by: Jesse Barnes <[email protected]>
* IPS driver: add GPU busy and turbo checkingJesse Barnes2010-08-031-13/+17
| | | | | | | | | Be sure to enable GPU turbo by default at load time and check GPU busy and MCP exceeded status correctly. Also fix up CPU power comparison and work around buggy MCH temp reporting. Signed-off-by: Jesse Barnes <[email protected]> Signed-off-by: Matthew Garrett <[email protected]>
* x86 platform driver: intelligent power sharing driverJesse Barnes2010-08-031-0/+1655
Intel Core i3/5 platforms with integrated graphics support both CPU and GPU turbo mode. CPU turbo mode is opportunistic: the CPU will use any available power to increase core frequencies if thermal headroom is available. The GPU side is more manual however; the graphics driver must monitor GPU power and temperature and coordinate with a core thermal driver to take advantage of available thermal and power headroom in the package. The intelligent power sharing (IPS) driver is intended to coordinate this activity by monitoring MCP (multi-chip package) temperature and power, allowing the CPU and/or GPU to increase their power consumption, and thus performance, when possible. The goal is to maximize performance within a given platform's TDP (thermal design point). Signed-off-by: Jesse Barnes <[email protected]> Signed-off-by: Matthew Garrett <[email protected]>