diff options
| author | Jakub Kicinski <[email protected]> | 2025-08-01 17:07:54 +0000 |
|---|---|---|
| committer | Jakub Kicinski <[email protected]> | 2025-08-05 23:01:26 +0000 |
| commit | e407fceeaf1b2959892b4fc9b584843d3f2bfc05 (patch) | |
| tree | e54d4f743eca0c07ee53691dae72dfca79dd2c05 /tools/testing/selftests/drivers/net/napi_threaded.py | |
| parent | net: ftgmac100: fix potential NULL pointer access in ftgmac100_phy_disconnect (diff) | |
| download | kernel-e407fceeaf1b2959892b4fc9b584843d3f2bfc05.tar.gz kernel-e407fceeaf1b2959892b4fc9b584843d3f2bfc05.zip | |
eth: fbnic: remove the debugging trick of super high page bias
Alex added page bias of LONG_MAX, which is admittedly quite
a clever way of catching overflows of the pp ref count.
The page pool code was "optimized" to leave the ref at 1
for freed pages so it can't catch basic bugs by itself any more.
(Something we should probably address under DEBUG_NET...)
Unfortunately for fbnic since commit f7dc3248dcfb ("skbuff: Optimization
of SKB coalescing for page pool") core _may_ actually take two extra
pp refcounts, if one of them is returned before driver gives up the bias
the ret < 0 check in page_pool_unref_netmem() will trigger.
While at it add a FBNIC_ to the name of the driver constant.
Fixes: 0cb4c0a13723 ("eth: fbnic: Implement Rx queue alloc/start/stop/free")
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Jakub Kicinski <[email protected]>
Diffstat (limited to 'tools/testing/selftests/drivers/net/napi_threaded.py')
0 files changed, 0 insertions, 0 deletions
