aboutsummaryrefslogtreecommitdiffstats
path: root/tools/perf/ui/browsers/annotate.c
diff options
context:
space:
mode:
authorArnaldo Carvalho de Melo <[email protected]>2012-04-19 16:15:24 +0000
committerArnaldo Carvalho de Melo <[email protected]>2012-04-19 16:15:24 +0000
commit61e04b332e9417720c331eb39c96a4ccb1aa0460 (patch)
treeb9968045de00bef1a6e8770a1d2053e1509a42be /tools/perf/ui/browsers/annotate.c
parentperf annotate browser: Hide non jump target addresses in offset mode (diff)
downloadkernel-61e04b332e9417720c331eb39c96a4ccb1aa0460.tar.gz
kernel-61e04b332e9417720c331eb39c96a4ccb1aa0460.zip
perf annotate browser: Align jump labels
Find out at browser startup the max width and use it when rendering jump labels on the screen. Cc: David Ahern <[email protected]> Cc: Frederic Weisbecker <[email protected]> Cc: Mike Galbraith <[email protected]> Cc: Namhyung Kim <[email protected]> Cc: Paul Mackerras <[email protected]> Cc: Peter Zijlstra <[email protected]> Cc: Stephane Eranian <[email protected]> Link: http://lkml.kernel.org/n/[email protected] Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
Diffstat (limited to 'tools/perf/ui/browsers/annotate.c')
-rw-r--r--tools/perf/ui/browsers/annotate.c17
1 files changed, 13 insertions, 4 deletions
diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/browsers/annotate.c
index a1e942bb903b..c5ab21c50a74 100644
--- a/tools/perf/ui/browsers/annotate.c
+++ b/tools/perf/ui/browsers/annotate.c
@@ -31,6 +31,7 @@ struct annotate_browser {
bool hide_src_code;
bool use_offset;
bool searching_backwards;
+ u8 offset_width;
char search_bf[128];
};
@@ -92,10 +93,17 @@ static void annotate_browser__write(struct ui_browser *self, void *entry, int ro
if (!ab->use_offset)
addr += ab->start;
- if (bdl->jump_target || !ab->use_offset)
- printed = scnprintf(bf, sizeof(bf), " %" PRIx64 ":", addr);
- else
- printed = scnprintf(bf, sizeof(bf), " ");
+ if (!ab->use_offset) {
+ printed = scnprintf(bf, sizeof(bf), "%" PRIx64 ":", addr);
+ } else {
+ if (bdl->jump_target) {
+ printed = scnprintf(bf, sizeof(bf), "%*" PRIx64 ":",
+ ab->offset_width, addr);
+ } else {
+ printed = scnprintf(bf, sizeof(bf), "%*s ",
+ ab->offset_width, " ");
+ }
+ }
if (change_color)
color = ui_browser__set_color(self, HE_COLORSET_ADDR);
@@ -687,6 +695,7 @@ int symbol__tui_annotate(struct symbol *sym, struct map *map, int evidx,
annotate_browser__mark_jump_targets(&browser, size);
+ browser.offset_width = hex_width(size);
browser.b.nr_entries = browser.nr_entries;
browser.b.entries = &notes->src->source,
browser.b.width += 18; /* Percentage */