diff options
| author | Jim Mattson <[email protected]> | 2021-04-22 00:18:34 +0000 |
|---|---|---|
| committer | Peter Zijlstra <[email protected]> | 2021-04-22 12:36:01 +0000 |
| commit | 4b2f1e59229b9da319d358828cdfa4ddbc140769 (patch) | |
| tree | f53b83638635ae507f58751932438200e8898a2a /tools/perf/scripts/python/flamegraph.py | |
| parent | perf/x86/intel/uncore: Remove uncore extra PCI dev HSWEP_PCI_PCU_3 (diff) | |
| download | kernel-4b2f1e59229b9da319d358828cdfa4ddbc140769.tar.gz kernel-4b2f1e59229b9da319d358828cdfa4ddbc140769.zip | |
perf/x86/kvm: Fix Broadwell Xeon stepping in isolation_ucodes[]
The only stepping of Broadwell Xeon parts is stepping 1. Fix the
relevant isolation_ucodes[] entry, which previously enumerated
stepping 2.
Although the original commit was characterized as an optimization, it
is also a workaround for a correctness issue.
If a PMI arrives between kvm's call to perf_guest_get_msrs() and the
subsequent VM-entry, a stale value for the IA32_PEBS_ENABLE MSR may be
restored at the next VM-exit. This is because, unbeknownst to kvm, PMI
throttling may clear bits in the IA32_PEBS_ENABLE MSR. CPUs with "PEBS
isolation" don't suffer from this issue, because perf_guest_get_msrs()
doesn't report the IA32_PEBS_ENABLE value.
Fixes: 9b545c04abd4f ("perf/x86/kvm: Avoid unnecessary work in guest filtering")
Signed-off-by: Jim Mattson <[email protected]>
Signed-off-by: Peter Zijlstra (Intel) <[email protected]>
Reviewed-by: Peter Shier <[email protected]>
Acked-by: Andi Kleen <[email protected]>
Link: https://lkml.kernel.org/r/[email protected]
Diffstat (limited to 'tools/perf/scripts/python/flamegraph.py')
0 files changed, 0 insertions, 0 deletions
