diff options
| author | Arnaldo Carvalho de Melo <[email protected]> | 2016-04-08 14:31:24 +0000 |
|---|---|---|
| committer | Arnaldo Carvalho de Melo <[email protected]> | 2016-04-08 14:31:24 +0000 |
| commit | 3354cf71104de49326d19d2f9bdb1f66eea52ef4 (patch) | |
| tree | e0d9bab4e6909f3b8c66f83fc9275f1839bceea6 /tools/perf/builtin-script.c | |
| parent | perf script: Use readdir() instead of deprecated readdir_r() (diff) | |
| download | kernel-3354cf71104de49326d19d2f9bdb1f66eea52ef4.tar.gz kernel-3354cf71104de49326d19d2f9bdb1f66eea52ef4.zip | |
perf thread_map: Use readdir() instead of deprecated readdir_r()
The readdir() function is thread safe as long as just one thread uses a
DIR, which is the case in thread_map, so, to avoid breaking the build
with glibc-2.23.90 (upcoming 2.24), use it instead of readdir_r().
See: http://man7.org/linux/man-pages/man3/readdir.3.html
"However, in modern implementations (including the glibc implementation),
concurrent calls to readdir() that specify different directory streams
are thread-safe. In cases where multiple threads must read from the
same directory stream, using readdir() with external synchronization is
still preferable to the use of the deprecated readdir_r(3) function."
Noticed while building on a Fedora Rawhide docker container.
Cc: Adrian Hunter <[email protected]>
Cc: David Ahern <[email protected]>
Cc: Jiri Olsa <[email protected]>
Cc: Namhyung Kim <[email protected]>
Cc: Wang Nan <[email protected]>
Link: http://lkml.kernel.org/n/[email protected]
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
Diffstat (limited to 'tools/perf/builtin-script.c')
0 files changed, 0 insertions, 0 deletions
