diff options
| author | Leo Yan <[email protected]> | 2025-03-04 11:12:29 +0000 |
|---|---|---|
| committer | Namhyung Kim <[email protected]> | 2025-03-05 17:13:19 +0000 |
| commit | 2b747a86d84ff6c1c14c50494de74d1dc2aed427 (patch) | |
| tree | 63453a43f12fcc7b8d3c38903df0a5279e7e0aca /tools/perf/builtin-script.c | |
| parent | perf stat: Fix non-uniquified hybrid legacy events (diff) | |
| download | kernel-2b747a86d84ff6c1c14c50494de74d1dc2aed427.tar.gz kernel-2b747a86d84ff6c1c14c50494de74d1dc2aed427.zip | |
perf script: Make printing flags reliable
Add a check for the generated string of flags. Print out the raw number
if the string generation fails.
Use the SAMPLE_FLAGS_STR_ALIGNED_SIZE macro to replace the value '21'.
Reviewed-by: Ian Rogers <[email protected]>
Reviewed-by: James Clark <[email protected]>
Signed-off-by: Leo Yan <[email protected]>
Reviewed-by: Adrian Hunter <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Namhyung Kim <[email protected]>
Diffstat (limited to 'tools/perf/builtin-script.c')
| -rw-r--r-- | tools/perf/builtin-script.c | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c index d797cec4f054..8ca04293d335 100644 --- a/tools/perf/builtin-script.c +++ b/tools/perf/builtin-script.c @@ -1709,9 +1709,14 @@ static int perf_sample__fprintf_bts(struct perf_sample *sample, static int perf_sample__fprintf_flags(u32 flags, FILE *fp) { char str[SAMPLE_FLAGS_BUF_SIZE]; + int ret; + + ret = perf_sample__sprintf_flags(flags, str, sizeof(str)); + if (ret < 0) + return fprintf(fp, " raw flags:0x%-*x ", + SAMPLE_FLAGS_STR_ALIGNED_SIZE - 12, flags); - perf_sample__sprintf_flags(flags, str, sizeof(str)); - return fprintf(fp, " %-21s ", str); + return fprintf(fp, " %-*s ", SAMPLE_FLAGS_STR_ALIGNED_SIZE, str); } struct printer_data { |