diff options
| author | Luis Henriques <[email protected]> | 2023-09-29 09:12:06 +0000 |
|---|---|---|
| committer | Ilya Dryomov <[email protected]> | 2023-10-09 11:35:24 +0000 |
| commit | 42b71826fe5d01f3e6cdddc91f81d0e4afb91801 (patch) | |
| tree | 4a05605ad2394c6cf388760960dafade2ef69316 /tools/net/ynl/generated/netdev-user.h | |
| parent | ceph: fix incorrect revoked caps assert in ceph_fill_file_size() (diff) | |
| download | kernel-42b71826fe5d01f3e6cdddc91f81d0e4afb91801.tar.gz kernel-42b71826fe5d01f3e6cdddc91f81d0e4afb91801.zip | |
ceph: remove unnecessary IS_ERR() check in ceph_fname_to_usr()
Before returning, function ceph_fname_to_usr() does a final IS_ERR() check
in 'dir':
if ((dir != fname->dir) && !IS_ERR(dir)) {...}
This check is unnecessary because, if the 'dir' variable has changed to
something other than 'fname->dir' (it's initial value), that error check has
been performed already and, if there was indeed an error, it would have
been returned immediately.
Besides, this useless IS_ERR() is also confusing static analysis tools.
Reported-by: kernel test robot <[email protected]>
Reported-by: Dan Carpenter <[email protected]>
Closes: https://lore.kernel.org/r/[email protected]/
Signed-off-by: Luis Henriques <[email protected]>
Reviewed-by: Ilya Dryomov <[email protected]>
Signed-off-by: Ilya Dryomov <[email protected]>
Diffstat (limited to 'tools/net/ynl/generated/netdev-user.h')
0 files changed, 0 insertions, 0 deletions
