diff options
| author | Robin Murphy <[email protected]> | 2025-04-25 13:39:28 +0000 |
|---|---|---|
| committer | Christophe Leroy <[email protected]> | 2025-05-12 23:38:55 +0000 |
| commit | 152f33ee30ee6a7f4c15bedd7529dc5945315547 (patch) | |
| tree | 8088db3d2aa80acaffd9acbfbdaa9586a5c2d7b4 /scripts/gcc-plugins | |
| parent | bus: fsl-mc: increase MC_CMD_COMPLETION_TIMEOUT_MS value (diff) | |
| download | kernel-152f33ee30ee6a7f4c15bedd7529dc5945315547.tar.gz kernel-152f33ee30ee6a7f4c15bedd7529dc5945315547.zip | |
bus: fsl_mc: Fix driver_managed_dma check
Since it's not currently safe to take device_lock() in the IOMMU probe
path, that can race against really_probe() setting dev->driver before
attempting to bind. The race itself isn't so bad, since we're only
concerned with dereferencing dev->driver itself anyway, but sadly my
attempt to implement the check with minimal churn leads to a kind of
TOCTOU issue, where dev->driver becomes valid after to_fsl_mc_driver(NULL)
is already computed, and thus the check fails to work as intended.
Will and I both hit this with the platform bus, but the pattern here is
the same, so fix it for correctness too.
Reported-by: Will McVicker <[email protected]>
Fixes: bcb81ac6ae3c ("iommu: Get DT/ACPI parsing into the proper probe path")
Signed-off-by: Robin Murphy <[email protected]>
Reviewed-by: Will McVicker <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Christophe Leroy <[email protected]>
Diffstat (limited to 'scripts/gcc-plugins')
0 files changed, 0 insertions, 0 deletions
