diff options
| author | Gerhard Engleder <[email protected]> | 2023-12-26 20:55:36 +0000 |
|---|---|---|
| committer | Jakub Kicinski <[email protected]> | 2024-01-03 00:19:18 +0000 |
| commit | 501869fecfbc00d20d07c1a5f1a49af8fb903d44 (patch) | |
| tree | 24b579eec496192d478ee1aafa942b7804e03123 /net/unix/unix_bpf.c | |
| parent | Merge branch 'bug-fixes-for-rss-symmetric-xor' (diff) | |
| download | kernel-501869fecfbc00d20d07c1a5f1a49af8fb903d44.tar.gz kernel-501869fecfbc00d20d07c1a5f1a49af8fb903d44.zip | |
net: ethtool: Fix symmetric-xor RSS RX flow hash check
Commit 13e59344fb9d ("net: ethtool: add support for symmetric-xor RSS hash")
adds a check to the ethtool set_rxnfc operation, which checks the RX
flow hash if the flag RXH_XFRM_SYM_XOR is set. This flag is introduced
with the same commit. It calls the ethtool get_rxfh operation to get the
RX flow hash data. If get_rxfh is not supported, then EOPNOTSUPP is
returned.
There are driver like tsnep, macb, asp2, genet, gianfar, mtk, ... which
support the ethtool operation set_rxnfc but not get_rxfh. This results
in EOPNOTSUPP returned by ethtool_set_rxnfc() without actually calling
the ethtool operation set_rxnfc. Thus, set_rxnfc got broken for all
these drivers.
Check RX flow hash in ethtool_set_rxnfc() only if driver supports RX
flow hash.
Fixes: 13e59344fb9d ("net: ethtool: add support for symmetric-xor RSS hash")
Signed-off-by: Gerhard Engleder <[email protected]>
Reviewed-by: Ravi Gunasekaran <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Jakub Kicinski <[email protected]>
Diffstat (limited to 'net/unix/unix_bpf.c')
0 files changed, 0 insertions, 0 deletions