diff options
| author | David Chinner <[email protected]> | 2008-04-10 02:24:30 +0000 |
|---|---|---|
| committer | Lachlan McIlroy <[email protected]> | 2008-04-18 02:02:20 +0000 |
| commit | b911ca0472c3762d2bafc4d21e432a9056844064 (patch) | |
| tree | 4ed23766782938e7316d087fa542cdbfd5fcadd7 /net/unix/sysctl_net_unix.c | |
| parent | [XFS] Check for errors when changing buffer pointers. (diff) | |
| download | kernel-b911ca0472c3762d2bafc4d21e432a9056844064.tar.gz kernel-b911ca0472c3762d2bafc4d21e432a9056844064.zip | |
[XFS] Sanitise xfs_log_force error checking.
xfs_log_force() is declared to return an error, but we almost never check
it. We don't need to check it in most cases; if there's a log I/O error
then we'll be shutting down the filesystem anyway and that means we'll
catch the error somewhere else.
However, on certain calls we should be returning an error - sync
transactions, fsync, sync writes, etc. so this isn't a pure black and
white distinction. Hence make xfs_log_force() a void function that issues
a warning to the syslog on error, and call _xfs_log_force() in all the
places where we actually care about the error status returned.
SGI-PV: 980084
SGI-Modid: xfs-linux-melb:xfs-kern:30832a
Signed-off-by: David Chinner <[email protected]>
Signed-off-by: Niv Sardi <[email protected]>
Signed-off-by: Lachlan McIlroy <[email protected]>
Diffstat (limited to 'net/unix/sysctl_net_unix.c')
0 files changed, 0 insertions, 0 deletions