diff options
| author | Peter Ujfalusi <[email protected]> | 2025-02-06 08:46:42 +0000 |
|---|---|---|
| committer | Mark Brown <[email protected]> | 2025-02-06 11:33:48 +0000 |
| commit | 6fd60136d256b3b948333ebdb3835f41a95ab7ef (patch) | |
| tree | f2efe82896f29b328a21afd98aca9a9724d08a48 /net/unix/garbage.c | |
| parent | ASoC: cs35l41: Fallback to using HID for system_name if no SUB is available (diff) | |
| download | kernel-6fd60136d256b3b948333ebdb3835f41a95ab7ef.tar.gz kernel-6fd60136d256b3b948333ebdb3835f41a95ab7ef.zip | |
ASoC: SOF: ipc4-topology: Harden loops for looking up ALH copiers
Other, non DAI copier widgets could have the same stream name (sname) as
the ALH copier and in that case the copier->data is NULL, no alh_data is
attached, which could lead to NULL pointer dereference.
We could check for this NULL pointer in sof_ipc4_prepare_copier_module()
and avoid the crash, but a similar loop in sof_ipc4_widget_setup_comp_dai()
will miscalculate the ALH device count, causing broken audio.
The correct fix is to harden the matching logic by making sure that the
1. widget is a DAI widget - so dai = w->private is valid
2. the dai (and thus the copier) is ALH copier
Fixes: a150345aa758 ("ASoC: SOF: ipc4-topology: add SoundWire/ALH aggregation support")
Reported-by: Seppo Ingalsuo <[email protected]>
Link: https://github.com/thesofproject/sof/pull/9652
Signed-off-by: Peter Ujfalusi <[email protected]>
Reviewed-by: Liam Girdwood <[email protected]>
Reviewed-by: Ranjani Sridharan <[email protected]>
Reviewed-by: Bard Liao <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Mark Brown <[email protected]>
Diffstat (limited to 'net/unix/garbage.c')
0 files changed, 0 insertions, 0 deletions
