diff options
| author | Cong Wang <[email protected]> | 2017-07-09 20:19:55 +0000 |
|---|---|---|
| committer | Linus Torvalds <[email protected]> | 2017-07-09 21:37:19 +0000 |
| commit | f991af3daabaecff34684fd51fac80319d1baad1 (patch) | |
| tree | 7f71fafa6bf93eb11a214aa9758036482923ee0b /net/unix/af_unix.c | |
| parent | Merge branch 'x86-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/ker... (diff) | |
| download | kernel-f991af3daabaecff34684fd51fac80319d1baad1.tar.gz kernel-f991af3daabaecff34684fd51fac80319d1baad1.zip | |
mqueue: fix a use-after-free in sys_mq_notify()
The retry logic for netlink_attachskb() inside sys_mq_notify()
is nasty and vulnerable:
1) The sock refcnt is already released when retry is needed
2) The fd is controllable by user-space because we already
release the file refcnt
so we when retry but the fd has been just closed by user-space
during this small window, we end up calling netlink_detachskb()
on the error path which releases the sock again, later when
the user-space closes this socket a use-after-free could be
triggered.
Setting 'sock' to NULL here should be sufficient to fix it.
Reported-by: GeneBlue <[email protected]>
Signed-off-by: Cong Wang <[email protected]>
Cc: Andrew Morton <[email protected]>
Cc: Manfred Spraul <[email protected]>
Cc: [email protected]
Signed-off-by: Linus Torvalds <[email protected]>
Diffstat (limited to 'net/unix/af_unix.c')
0 files changed, 0 insertions, 0 deletions
