diff options
| author | Yong Zhang <[email protected]> | 2011-11-09 08:04:51 +0000 |
|---|---|---|
| committer | Ingo Molnar <[email protected]> | 2011-12-06 17:18:13 +0000 |
| commit | a33caeb118198286309859f014c0662f3ed54ed4 (patch) | |
| tree | c9bc38bef15bd7167ab27e1285d56a1e6cef4549 /net/unix/af_unix.c | |
| parent | ftrace: Fix hash record accounting bug (diff) | |
| download | kernel-a33caeb118198286309859f014c0662f3ed54ed4.tar.gz kernel-a33caeb118198286309859f014c0662f3ed54ed4.zip | |
lockdep, kmemcheck: Annotate ->lock in lockdep_init_map()
Since commit f59de89 ("lockdep: Clear whole lockdep_map on initialization"),
lockdep_init_map() will clear all the struct. But it will break
lock_set_class()/lock_set_subclass(). A typical race condition
is like below:
CPU A CPU B
lock_set_subclass(lockA);
lock_set_class(lockA);
lockdep_init_map(lockA);
/* lockA->name is cleared */
memset(lockA);
__lock_acquire(lockA);
/* lockA->class_cache[] is cleared */
register_lock_class(lockA);
look_up_lock_class(lockA);
WARN_ON_ONCE(class->name !=
lock->name);
lock->name = name;
So restore to what we have done before commit f59de89 but annotate
->lock with kmemcheck_mark_initialized() to suppress the kmemcheck
warning reported in commit f59de89.
Reported-by: Sergey Senozhatsky <[email protected]>
Reported-by: Borislav Petkov <[email protected]>
Suggested-by: Vegard Nossum <[email protected]>
Signed-off-by: Yong Zhang <[email protected]>
Cc: Tejun Heo <[email protected]>
Cc: David Rientjes <[email protected]>
Cc: <[email protected]>
Signed-off-by: Peter Zijlstra <[email protected]>
Link: http://lkml.kernel.org/r/20111109080451.GB8124@zhy
Signed-off-by: Ingo Molnar <[email protected]>
Diffstat (limited to 'net/unix/af_unix.c')
0 files changed, 0 insertions, 0 deletions
