diff options
| author | Pali Rohár <[email protected]> | 2024-10-14 11:43:23 +0000 |
|---|---|---|
| committer | Steve French <[email protected]> | 2025-01-29 23:09:34 +0000 |
| commit | 8b19dfb34d17e77a0809d433cc128b779282131b (patch) | |
| tree | e07a0ce7685e1ef9f354ed6148cea9002d6a64d7 /net/unix/af_unix.c | |
| parent | cifs: Remove intermediate object of failed create SFU call (diff) | |
| download | kernel-8b19dfb34d17e77a0809d433cc128b779282131b.tar.gz kernel-8b19dfb34d17e77a0809d433cc128b779282131b.zip | |
cifs: Fix getting and setting SACLs over SMB1
SMB1 callback get_cifs_acl_by_fid() currently ignores its last argument and
therefore ignores request for SACL_SECINFO. Fix this issue by correctly
propagating info argument from get_cifs_acl() and get_cifs_acl_by_fid() to
CIFSSMBGetCIFSACL() function and pass SACL_SECINFO when requested.
For accessing SACLs it is needed to open object with SYSTEM_SECURITY
access. Pass this flag when trying to get or set SACLs.
Same logic is in the SMB2+ code path.
This change fixes getting and setting of "system.cifs_ntsd_full" and
"system.smb3_ntsd_full" xattrs over SMB1 as currently it silentely ignored
SACL part of passed xattr buffer.
Fixes: 3970acf7ddb9 ("SMB3: Add support for getting and setting SACLs")
Signed-off-by: Pali Rohár <[email protected]>
Signed-off-by: Steve French <[email protected]>
Diffstat (limited to 'net/unix/af_unix.c')
0 files changed, 0 insertions, 0 deletions