diff options
| author | John Fastabend <[email protected]> | 2019-11-21 16:25:09 +0000 |
|---|---|---|
| committer | David S. Miller <[email protected]> | 2019-11-21 21:43:45 +0000 |
| commit | 8163999db445021f2651a8a47b5632483e8722ea (patch) | |
| tree | 044f73c60b4d6d2becf9a03c5c78170d7dbe1e98 /net/tipc/node.c | |
| parent | audit: Move audit_log_task declaration under CONFIG_AUDITSYSCALL (diff) | |
| download | kernel-8163999db445021f2651a8a47b5632483e8722ea.tar.gz kernel-8163999db445021f2651a8a47b5632483e8722ea.zip | |
bpf: skmsg, fix potential psock NULL pointer dereference
Report from Dan Carpenter,
net/core/skmsg.c:792 sk_psock_write_space()
error: we previously assumed 'psock' could be null (see line 790)
net/core/skmsg.c
789 psock = sk_psock(sk);
790 if (likely(psock && sk_psock_test_state(psock, SK_PSOCK_TX_ENABLED)))
Check for NULL
791 schedule_work(&psock->work);
792 write_space = psock->saved_write_space;
^^^^^^^^^^^^^^^^^^^^^^^^
793 rcu_read_unlock();
794 write_space(sk);
Ensure psock dereference on line 792 only occurs if psock is not null.
Reported-by: Dan Carpenter <[email protected]>
Fixes: 604326b41a6f ("bpf, sockmap: convert to generic sk_msg interface")
Signed-off-by: John Fastabend <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
Diffstat (limited to 'net/tipc/node.c')
0 files changed, 0 insertions, 0 deletions