diff options
| author | Nishanth Menon <[email protected]> | 2016-02-20 00:09:51 +0000 |
|---|---|---|
| committer | Guenter Roeck <[email protected]> | 2016-02-20 01:14:25 +0000 |
| commit | 000e0949148382c4962489593a2f05504c2a6771 (patch) | |
| tree | 0d4ae71256666f3f785bbae7e9f98bf89dab9ccf /net/tipc/node.c | |
| parent | hwmon: (ads1015) Handle negative conversion values correctly (diff) | |
| download | kernel-000e0949148382c4962489593a2f05504c2a6771.tar.gz kernel-000e0949148382c4962489593a2f05504c2a6771.zip | |
hwmon: (gpio-fan) Remove un-necessary speed_index lookup for thermal hook
Thermal hook gpio_fan_get_cur_state is only interested in knowing
the current speed index that was setup in the system, this is
already available as part of fan_data->speed_index which is always
set by set_fan_speed. Using get_fan_speed_index is useful when we
have no idea about the fan speed configuration (for example during
fan_ctrl_init).
When thermal framework invokes
gpio_fan_get_cur_state=>get_fan_speed_index via gpio_fan_get_cur_state
especially in a polled configuration for thermal governor, we
basically hog the i2c interface to the extent that other functions
fail to get any traffic out :(.
Instead, just provide the last state set in the driver - since the gpio
fan driver is responsible for the fan state immaterial of override, the
fan_data->speed_index should accurately reflect the state.
Fixes: b5cf88e46bad ("(gpio-fan): Add thermal control hooks")
Reported-by: Tony Lindgren <[email protected]>
Cc: Guenter Roeck <[email protected]>
Cc: Eduardo Valentin <[email protected]>
Signed-off-by: Nishanth Menon <[email protected]>
Cc: [email protected]
Signed-off-by: Guenter Roeck <[email protected]>
Diffstat (limited to 'net/tipc/node.c')
0 files changed, 0 insertions, 0 deletions
