diff options
| author | Takashi Iwai <[email protected]> | 2021-01-23 15:57:30 +0000 |
|---|---|---|
| committer | Takashi Iwai <[email protected]> | 2021-01-23 15:59:24 +0000 |
| commit | 23b53d4417426edc7c3078e1c1530c242e496c1e (patch) | |
| tree | 63999a0395d92e7c3f2b7c54aab0070c6d49135a /net/lapb/lapb_out.c | |
| parent | ALSA: hda/realtek: Enable headset of ASUS B1400CEPE with ALC256 (diff) | |
| download | kernel-23b53d4417426edc7c3078e1c1530c242e496c1e.tar.gz kernel-23b53d4417426edc7c3078e1c1530c242e496c1e.zip | |
ALSA: pcm: One more dependency for hw constraints
The fix for a long-standing USB-audio bug required one more dependency
variable to be added to the hw constraints. Unfortunately I didn't
realize at debugging that the new addition may result in the overflow
of the dependency array of each snd_pcm_hw_rule (up to three plus a
sentinel), because USB-audio driver adds one more dependency only for
a certain device and bus, hence it works as is for many devices. But
in a bad case, a simple open always results in -EINVAL (with kernel
WARNING if CONFIG_SND_DEBUG is set) no matter what is passed.
Since the dependencies are real and unavoidable (USB-audio restricts
the hw_params per looping over the format/rate/channels combos), the
only good solution seems to raise the bar for one more dependency for
snd_pcm_hw_rule -- so does this patch: now the hw constraint
dependencies can be up to four.
Fixes: 506c203cc3de ("ALSA: usb-audio: Fix hw constraints dependencies")
Reported-by: Jamie Heilman <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
Diffstat (limited to 'net/lapb/lapb_out.c')
0 files changed, 0 insertions, 0 deletions
