diff options
| author | Gal Pressman <[email protected]> | 2025-07-15 14:07:54 +0000 |
|---|---|---|
| committer | Jakub Kicinski <[email protected]> | 2025-07-16 22:03:56 +0000 |
| commit | 410b0ace8891a324d31efdc445b07b0e3054a68c (patch) | |
| tree | 50fcf3d4921a9da0fa6a038cef668f78734a47aa /net/ipv4/tcp_input.c | |
| parent | selftests: rtnetlink: fix addrlft test flakiness on power-saving systems (diff) | |
| download | kernel-410b0ace8891a324d31efdc445b07b0e3054a68c.tar.gz kernel-410b0ace8891a324d31efdc445b07b0e3054a68c.zip | |
ethtool: Don't check for RXFH fields conflict when no input_xfrm is requested
The requirement of ->get_rxfh_fields() in ethtool_set_rxfh() is there to
verify that we have no conflict of input_xfrm with the RSS fields
options, there is no point in doing it if input_xfrm is not
supported/requested.
This is under the assumption that a driver that supports input_xfrm will
also support ->get_rxfh_fields(), so add a WARN_ON() to
ethtool_check_ops() to verify it, and remove the op NULL check.
This fixes the following error in mlx4_en, which doesn't support
getting/setting RXFH fields.
$ ethtool --set-rxfh-indir eth2 hfunc xor
Cannot set RX flow hash configuration: Operation not supported
Fixes: 72792461c8e8 ("net: ethtool: don't mux RXFH via rxnfc callbacks")
Reviewed-by: Dragos Tatulea <[email protected]>
Signed-off-by: Gal Pressman <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Jakub Kicinski <[email protected]>
Diffstat (limited to 'net/ipv4/tcp_input.c')
0 files changed, 0 insertions, 0 deletions
