diff options
| author | Vladimir Oltean <[email protected]> | 2023-09-06 14:16:09 +0000 |
|---|---|---|
| committer | Jakub Kicinski <[email protected]> | 2023-09-07 18:19:42 +0000 |
| commit | 1b36955cc048c8ff6ba448dbf4be0e52f59f2963 (patch) | |
| tree | c0a05d117fe6a4743c521e62dd9ba6d1f6a2d8b9 /net/ipv4/tcp.c | |
| parent | Revert "net: team: do not use dynamic lockdep key" (diff) | |
| download | kernel-1b36955cc048c8ff6ba448dbf4be0e52f59f2963.tar.gz kernel-1b36955cc048c8ff6ba448dbf4be0e52f59f2963.zip | |
net: enetc: distinguish error from valid pointers in enetc_fixup_clear_rss_rfs()
enetc_psi_create() returns an ERR_PTR() or a valid station interface
pointer, but checking for the non-NULL quality of the return code blurs
that difference away. So if enetc_psi_create() fails, we call
enetc_psi_destroy() when we shouldn't. This will likely result in
crashes, since enetc_psi_create() cleans up everything after itself when
it returns an ERR_PTR().
Fixes: f0168042a212 ("net: enetc: reimplement RFS/RSS memory clearing as PCI quirk")
Reported-by: Dan Carpenter <[email protected]>
Closes: https://lore.kernel.org/netdev/[email protected]/
Suggested-by: Dan Carpenter <[email protected]>
Signed-off-by: Vladimir Oltean <[email protected]>
Reviewed-by: Simon Horman <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Jakub Kicinski <[email protected]>
Diffstat (limited to 'net/ipv4/tcp.c')
0 files changed, 0 insertions, 0 deletions