diff options
| author | Xiu Jianfeng <[email protected]> | 2023-09-06 10:33:12 +0000 |
|---|---|---|
| committer | Andrew Morton <[email protected]> | 2023-10-04 17:32:21 +0000 |
| commit | 7fa38d0ea00ffe2cd3c95c96c85221b8ae221875 (patch) | |
| tree | c69cae9292de0ff50d7a918fb416cb2fb67a540d /mm/mm_init.c | |
| parent | mm/damon/core: remove 'struct target *' parameter from damon_aggregated trace... (diff) | |
| download | kernel-7fa38d0ea00ffe2cd3c95c96c85221b8ae221875.tar.gz kernel-7fa38d0ea00ffe2cd3c95c96c85221b8ae221875.zip | |
mm: remove duplicated vma->vm_flags check when expanding stack
expand_upwards() and expand_downwards() will return -EFAULT if VM_GROWSUP
or VM_GROWSDOWN is not correctly set in vma->vm_flags, however in
!CONFIG_STACK_GROWSUP case, expand_stack_locked() returns -EINVAL first if
!(vma->vm_flags & VM_GROWSDOWN) before calling expand_downwards(), to keep
the consistency with CONFIG_STACK_GROWSUP case, remove this check.
The usages of this function are as below:
A:fs/exec.c
ret = expand_stack_locked(vma, stack_base);
if (ret)
ret = -EFAULT;
or
B:mm/memory.c mm/mmap.c
if (expand_stack_locked(vma, addr))
return NULL;
which means the return value will not propagate to other places, so I
believe there is no user-visible effects of this change, and it's
unnecessary to backport to earlier versions.
Link: https://lkml.kernel.org/r/[email protected]
Fixes: f440fa1ac955 ("mm: make find_extend_vma() fail if write lock not held")
Signed-off-by: Xiu Jianfeng <[email protected]>
Cc: Liam R. Howlett <[email protected]>
Cc: Matthew Wilcox (Oracle) <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Diffstat (limited to 'mm/mm_init.c')
0 files changed, 0 insertions, 0 deletions
