aboutsummaryrefslogtreecommitdiffstats
path: root/lib/test_vmalloc.c
diff options
context:
space:
mode:
authorMiles Chen <[email protected]>2021-09-02 21:57:13 +0000
committerLinus Torvalds <[email protected]>2021-09-03 16:58:14 +0000
commitbdbda735508ca83341899a77f143e4d5c58007b3 (patch)
tree57128ca5fe6b698348ab0383d2ff25aa5a5a0a05 /lib/test_vmalloc.c
parentinclude/linux/mmzone.h: avoid a warning in sparse memory support (diff)
downloadkernel-bdbda735508ca83341899a77f143e4d5c58007b3.tar.gz
kernel-bdbda735508ca83341899a77f143e4d5c58007b3.zip
mm/sparse: clarify pgdat_to_phys
Clarify pgdat_to_phys() by testing if pgdat == &contig_page_data when CONFIG_NUMA=n. We only expect contig_page_data in such case, so we use &contig_page_data directly instead of pgdat. No functional change intended when CONFIG_BUG_VM=n. Comment from Mark [1]: " ... and I reckon it'd be clearer and more robust to define pgdat_to_phys() in the same ifdefs as contig_page_data so that these, stay in-sync. e.g. have: | #ifdef CONFIG_NUMA | #define pgdat_to_phys(x) virt_to_phys(x) | #else /* CONFIG_NUMA */ | | extern struct pglist_data contig_page_data; | ... | #define pgdat_to_phys(x) __pa_symbol(&contig_page_data) | | #endif /* CONIFIG_NUMA */ " [1] https://lore.kernel.org/linux-arm-kernel/[email protected]/ Link: https://lkml.kernel.org/r/[email protected] Signed-off-by: Miles Chen <[email protected]> Reviewed-by: David Hildenbrand <[email protected]> Acked-by: Mike Rapoport <[email protected]> Cc: Mark Rutland <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
Diffstat (limited to 'lib/test_vmalloc.c')
0 files changed, 0 insertions, 0 deletions