diff options
| author | Fangrui Song <[email protected]> | 2023-05-12 02:25:28 +0000 |
|---|---|---|
| committer | Kees Cook <[email protected]> | 2023-05-16 21:32:00 +0000 |
| commit | 60592fb6b67c653beaa2e7acad9a9d7aa0b71dff (patch) | |
| tree | 27f14ecfcbf21dd70c09f2b27764a0c38a1eacd0 /lib/string.c | |
| parent | Linux 6.4-rc2 (diff) | |
| download | kernel-60592fb6b67c653beaa2e7acad9a9d7aa0b71dff.tar.gz kernel-60592fb6b67c653beaa2e7acad9a9d7aa0b71dff.zip | |
coredump, vmcore: Set p_align to 4 for PT_NOTE
Tools like readelf/llvm-readelf use p_align to parse a PT_NOTE program
header as an array of 4-byte entries or 8-byte entries. Currently, there
are workarounds[1] in place for Linux to treat p_align==0 as 4. However,
it would be more appropriate to set the correct alignment so that tools
do not have to rely on guesswork. FreeBSD coredumps set p_align to 4 as
well.
[1]: https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=82ed9683ec099d8205dc499ac84febc975235af6
[2]: https://reviews.llvm.org/D150022
Signed-off-by: Fangrui Song <[email protected]>
Signed-off-by: Kees Cook <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Diffstat (limited to 'lib/string.c')
0 files changed, 0 insertions, 0 deletions