diff options
| author | Hans Verkuil <[email protected]> | 2025-02-24 14:40:58 +0000 |
|---|---|---|
| committer | Hans Verkuil <[email protected]> | 2025-03-12 15:43:51 +0000 |
| commit | d9e7c172a7f247f7ef0b151fa8c8f044b6a2a070 (patch) | |
| tree | 4d28d2839e79d0c7f1180f6c4a04a5477c0dcda6 /lib/net_utils.c | |
| parent | Linux 6.14-rc1 (diff) | |
| download | kernel-d9e7c172a7f247f7ef0b151fa8c8f044b6a2a070.tar.gz kernel-d9e7c172a7f247f7ef0b151fa8c8f044b6a2a070.zip | |
media: rtl2832_sdr: assign vb2 lock before vb2_queue_init
Commit c780d01cf1a6 ("media: vb2: vb2_core_queue_init(): sanity check lock
and wait_prepare/finish") added a sanity check to ensure that if there are
no wait_prepare/finish callbacks set by the driver, then the vb2_queue lock
must be set, since otherwise the vb2 core cannot do correct locking.
The rtl2832_sdr.c triggered this warning: it turns out that while the
driver does set this lock, it sets it too late. So move it up to before
the vb2_queue_init() call.
Reported-by: Arthur Marsh <[email protected]>
Closes: https://lore.kernel.org/linux-media/20241211042355.8479-1-user@am64/
Fixes: 8fcd2795d22a ("media: rtl2832_sdr: drop vb2_ops_wait_prepare/finish")
Cc: [email protected]
Reviewed-by: Mauro Carvalho Chehab <[email protected]>
Signed-off-by: Hans Verkuil <[email protected]>
Diffstat (limited to 'lib/net_utils.c')
0 files changed, 0 insertions, 0 deletions