diff options
| author | Ard Biesheuvel <[email protected]> | 2022-12-13 16:13:10 +0000 |
|---|---|---|
| committer | Herbert Xu <[email protected]> | 2022-12-30 14:56:27 +0000 |
| commit | aa9695157f65c55e5c85a1c194859d3c03e68018 (patch) | |
| tree | 92cab03ac269b23b3211b3d5ae41317c389fa536 /lib/mpi/mpicoder.c | |
| parent | crypto: arm/sha1 - Fix clang function cast warnings (diff) | |
| download | kernel-aa9695157f65c55e5c85a1c194859d3c03e68018.tar.gz kernel-aa9695157f65c55e5c85a1c194859d3c03e68018.zip | |
crypto: scatterwalk - use kmap_local() not kmap_atomic()
kmap_atomic() is used to create short-lived mappings of pages that may
not be accessible via the kernel direct map. This is only needed on
32-bit architectures that implement CONFIG_HIGHMEM, but it can be used
on 64-bit other architectures too, where the returned mapping is simply
the kernel direct address of the page.
However, kmap_atomic() does not support migration on CONFIG_HIGHMEM
configurations, due to the use of per-CPU kmap slots, and so it disables
preemption on all architectures, not just the 32-bit ones. This implies
that all scatterwalk based crypto routines essentially execute with
preemption disabled all the time, which is less than ideal.
So let's switch scatterwalk_map/_unmap and the shash/ahash routines to
kmap_local() instead, which serves a similar purpose, but without the
resulting impact on preemption on architectures that have no need for
CONFIG_HIGHMEM.
Cc: Eric Biggers <[email protected]>
Cc: Herbert Xu <[email protected]>
Cc: "Elliott, Robert (Servers)" <[email protected]>
Signed-off-by: Ard Biesheuvel <[email protected]>
Signed-off-by: Herbert Xu <[email protected]>
Diffstat (limited to 'lib/mpi/mpicoder.c')
0 files changed, 0 insertions, 0 deletions
