diff options
| author | Hans de Goede <[email protected]> | 2025-11-02 19:09:21 +0000 |
|---|---|---|
| committer | Mark Brown <[email protected]> | 2025-11-05 13:08:48 +0000 |
| commit | 3cd2018e15b3d66d2187d92867e265f45ad79e6f (patch) | |
| tree | d320db654bb1cbc913d175465e88013e0625ac64 /lib/mpi/mpi-scan.c | |
| parent | Linux 6.18-rc4 (diff) | |
| download | kernel-3cd2018e15b3d66d2187d92867e265f45ad79e6f.tar.gz kernel-3cd2018e15b3d66d2187d92867e265f45ad79e6f.zip | |
spi: Try to get ACPI GPIO IRQ earlier
Since commit d24cfee7f63d ("spi: Fix acpi deferred irq probe"), the
acpi_dev_gpio_irq_get() call gets delayed till spi_probe() is called
on the SPI device.
If there is no driver for the SPI device then the move to spi_probe()
results in acpi_dev_gpio_irq_get() never getting called. This may
cause problems by leaving the GPIO pin floating because this call is
responsible for setting up the GPIO pin direction and/or bias according
to the values from the ACPI tables.
Re-add the removed acpi_dev_gpio_irq_get() in acpi_register_spi_device()
to ensure the GPIO pin is always correctly setup, while keeping the
acpi_dev_gpio_irq_get() call added to spi_probe() to deal with
-EPROBE_DEFER returns caused by the GPIO controller not having a driver
yet.
Link: https://bbs.archlinux.org/viewtopic.php?id=302348
Fixes: d24cfee7f63d ("spi: Fix acpi deferred irq probe")
Cc: [email protected]
Signed-off-by: Hans de Goede <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Mark Brown <[email protected]>
Diffstat (limited to 'lib/mpi/mpi-scan.c')
0 files changed, 0 insertions, 0 deletions