diff options
| author | Jason Low <[email protected]> | 2014-06-11 18:37:22 +0000 |
|---|---|---|
| committer | Ingo Molnar <[email protected]> | 2014-07-05 09:25:42 +0000 |
| commit | 0d968dd8c6aced585b86fa7ba8ce4573bf19e848 (patch) | |
| tree | 08d135faf746fc75290f3f16c71eb651b6fbe948 /lib/lockref.c | |
| parent | locking/mutexes: Delete the MUTEX_SHOW_NO_WAITER macro (diff) | |
| download | kernel-0d968dd8c6aced585b86fa7ba8ce4573bf19e848.tar.gz kernel-0d968dd8c6aced585b86fa7ba8ce4573bf19e848.zip | |
locking/mutexes: Try to acquire mutex only if it is unlocked
Upon entering the slowpath in __mutex_lock_common(), we try once more to
acquire the mutex. We only try to acquire if (lock->count >= 0). However,
what we actually want here is to try to acquire if the mutex is unlocked
(lock->count == 1).
This patch changes it so that we only try-acquire the mutex upon entering
the slowpath if it is unlocked, rather than if the lock count is non-negative.
This helps further reduce unnecessary atomic xchg() operations.
Furthermore, this patch uses !mutex_is_locked(lock) to do the initial
checks for if the lock is free rather than directly calling atomic_read()
on the lock->count, in order to improve readability.
Signed-off-by: Jason Low <[email protected]>
Acked-by: Waiman Long <[email protected]>
Signed-off-by: Peter Zijlstra <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: Linus Torvalds <[email protected]>
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Ingo Molnar <[email protected]>
Diffstat (limited to 'lib/lockref.c')
0 files changed, 0 insertions, 0 deletions
