diff options
| author | Hugh Dickins <[email protected]> | 2014-12-02 23:59:39 +0000 |
|---|---|---|
| committer | Linus Torvalds <[email protected]> | 2014-12-03 17:36:03 +0000 |
| commit | 2022b4d18a491a578218ce7a4eca8666db895a73 (patch) | |
| tree | e18b23dd07cd0a361143556e184262e992d2b4c9 /lib/genalloc.c | |
| parent | fat: fix oops on corrupted vfat fs (diff) | |
| download | kernel-2022b4d18a491a578218ce7a4eca8666db895a73.tar.gz kernel-2022b4d18a491a578218ce7a4eca8666db895a73.zip | |
mm: fix swapoff hang after page migration and fork
I've been seeing swapoff hangs in recent testing: it's cycling around
trying unsuccessfully to find an mm for some remaining pages of swap.
I have been exercising swap and page migration more heavily recently,
and now notice a long-standing error in copy_one_pte(): it's trying to
add dst_mm to swapoff's mmlist when it finds a swap entry, but is doing
so even when it's a migration entry or an hwpoison entry.
Which wouldn't matter much, except it adds dst_mm next to src_mm,
assuming src_mm is already on the mmlist: which may not be so. Then if
pages are later swapped out from dst_mm, swapoff won't be able to find
where to replace them.
There's already a !non_swap_entry() test for stats: move that up before
the swap_duplicate() and the addition to mmlist.
Signed-off-by: Hugh Dickins <[email protected]>
Cc: Kelley Nielsen <[email protected]>
Cc: <[email protected]> [2.6.18+]
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
Diffstat (limited to 'lib/genalloc.c')
0 files changed, 0 insertions, 0 deletions
