aboutsummaryrefslogtreecommitdiffstats
path: root/lib/flex_array.c
diff options
context:
space:
mode:
authorHidetoshi Seto <[email protected]>2009-07-29 22:04:14 +0000
committerLinus Torvalds <[email protected]>2009-07-30 02:10:36 +0000
commitcab8bd3410d448279e3bd0fbf96d31db0bf770fa (patch)
tree2ad9262b2c4d10cc705c8553015caff06a29de11 /lib/flex_array.c
parentpps.h needs <linux/types.h> (diff)
downloadkernel-cab8bd3410d448279e3bd0fbf96d31db0bf770fa.tar.gz
kernel-cab8bd3410d448279e3bd0fbf96d31db0bf770fa.zip
sysrq, kdump: make sysrq-c consistent
commit d6580a9f15238b87e618310c862231ae3f352d2d ("kexec: sysrq: simplify sysrq-c handler") changed the behavior of sysrq-c to unconditional dereference of NULL pointer. So in cases with CONFIG_KEXEC, where crash_kexec() was directly called from sysrq-c before, now it can be said that a step of "real oops" was inserted before starting kdump. However, in contrast to oops via SysRq-c from keyboard which results in panic due to in_interrupt(), oops via "echo c > /proc/sysrq-trigger" will not become panic unless panic_on_oops=1. It means that even if dump is properly configured to be taken on panic, the sysrq-c from proc interface might not start crashdump while the sysrq-c from keyboard can start crashdump. This confuses traditional users of kdump, i.e. people who expect sysrq-c to do common behavior in both of the keyboard and proc interface. This patch brings the keyboard and proc interface behavior of sysrq-c in line, by forcing panic_on_oops=1 before oops in sysrq-c handler. And some updates in documentation are included, to clarify that there is no longer dependency with CONFIG_KEXEC, and that now the system can just crash by sysrq-c if no dump mechanism is configured. Signed-off-by: Hidetoshi Seto <[email protected]> Cc: Lai Jiangshan <[email protected]> Cc: Ken'ichi Ohmichi <[email protected]> Acked-by: Neil Horman <[email protected]> Acked-by: Vivek Goyal <[email protected]> Cc: Brayan Arraes <[email protected]> Cc: Eric W. Biederman <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
Diffstat (limited to 'lib/flex_array.c')
0 files changed, 0 insertions, 0 deletions