diff options
| author | Herton Ronaldo Krzesinski <[email protected]> | 2010-03-19 22:37:26 +0000 |
|---|---|---|
| committer | James Bottomley <[email protected]> | 2010-03-27 19:12:37 +0000 |
| commit | cf7474451c3a3cf07811abbf2a39536d33046c36 (patch) | |
| tree | 7e9336395862432e8f2146f490fbc936705ac610 /lib/debugobjects.c | |
| parent | [SCSI] qla2xxx: Updated version number to 8.03.02-k2. (diff) | |
| download | kernel-cf7474451c3a3cf07811abbf2a39536d33046c36.tar.gz kernel-cf7474451c3a3cf07811abbf2a39536d33046c36.zip | |
[SCSI] advansys: fix regression with request_firmware change
On newer kernels users of advansys module are reporting system hang when
trying to load it without firmware files present. After looking closely
at description on https://qa.mandriva.com/show_bug.cgi?id=53220, I think
this is related to commit "[SCSI] advansys: use request_firmware". The
problem is that after switch to request_firmware, asc_dvc->err_code
isn't being set when firmware files aren't found or loading fails.
err_code is used by the driver to judge if there was a fatal error or
not, as can be seen for example on advansys_board_found, which will only
return -ENODEV when err_code is set. Because err_code isn't being set
when request_firmware fails, this is a change of behaviour of the code
before request_firmware addition, making it continue to load and it
fails later as the firmware wasn't really loaded.
Signed-off-by: Herton Ronaldo Krzesinski <[email protected]>
Signed-off-by: James Bottomley <[email protected]>
Diffstat (limited to 'lib/debugobjects.c')
0 files changed, 0 insertions, 0 deletions