diff options
| author | KAMEZAWA Hiroyuki <[email protected]> | 2010-12-29 22:07:11 +0000 |
|---|---|---|
| committer | Linus Torvalds <[email protected]> | 2010-12-30 18:07:06 +0000 |
| commit | ebb76ce16daf6908dc030dec1c00827d37129fe5 (patch) | |
| tree | 28abdc67466bb5d8d4566e36c914518b0533b4bf /fs/ubifs/commit.c | |
| parent | update Documentation/filesystems/Locking (diff) | |
| download | kernel-ebb76ce16daf6908dc030dec1c00827d37129fe5.tar.gz kernel-ebb76ce16daf6908dc030dec1c00827d37129fe5.zip | |
memcg: fix wrong VM_BUG_ON() in try_charge()'s mm->owner check
At __mem_cgroup_try_charge(), VM_BUG_ON(!mm->owner) is checked.
But as commented in mem_cgroup_from_task(), mm->owner can be NULL
in some racy case. This check of VM_BUG_ON() is bad.
A possible story to hit this is at swapoff()->try_to_unuse(). It passes
mm_struct to mem_cgroup_try_charge_swapin() while mm->owner is NULL. If we
can't get proper mem_cgroup from swap_cgroup information, mm->owner is used
as charge target and we see NULL.
Cc: Daisuke Nishimura <[email protected]>
Cc: KOSAKI Motohiro <[email protected]>
Reported-by: Hugh Dickins <[email protected]>
Reported-by: Thomas Meyer <[email protected]>
Signed-off-by: KAMEZAWA Hiroyuki <[email protected]>
Reviewed-by: Balbir Singh <[email protected]>
Signed-off-by: Hugh Dickins <[email protected]>
Cc: [email protected]
Signed-off-by: Linus Torvalds <[email protected]>
Diffstat (limited to 'fs/ubifs/commit.c')
0 files changed, 0 insertions, 0 deletions
