diff options
| author | Dan Williams <[email protected]> | 2008-05-12 21:02:12 +0000 |
|---|---|---|
| committer | Linus Torvalds <[email protected]> | 2008-05-13 15:02:24 +0000 |
| commit | c8894419acf5e56851de9741c5047bebd78acd1f (patch) | |
| tree | 6294b87ebf31d577cd48880a201ff4b1a6a50ffc /fs/proc/array.c | |
| parent | tridentfb: improve clock setting accuracy (diff) | |
| download | kernel-c8894419acf5e56851de9741c5047bebd78acd1f.tar.gz kernel-c8894419acf5e56851de9741c5047bebd78acd1f.zip | |
md: fix raid5 'repair' operations
commit bd2ab67030e9116f1e4aae1289220255412b37fd "md: close a livelock window
in handle_parity_checks5" introduced a bug in handling 'repair' operations.
After a repair operation completes we clear the state bits tracking this
operation. However, they are cleared too early and this results in the code
deciding to re-run the parity check operation. Since we have done the repair
in memory the second check does not find a mismatch and thus does not do a
writeback.
Test results:
$ echo repair > /sys/block/md0/md/sync_action
$ cat /sys/block/md0/md/mismatch_cnt
51072
$ echo repair > /sys/block/md0/md/sync_action
$ cat /sys/block/md0/md/mismatch_cnt
0
(also fix incorrect indentation)
Cc: <[email protected]>
Tested-by: George Spelvin <[email protected]>
Acked-by: NeilBrown <[email protected]>
Signed-off-by: Dan Williams <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
Diffstat (limited to 'fs/proc/array.c')
0 files changed, 0 insertions, 0 deletions