diff options
| author | Scott Valentine <[email protected]> | 2009-11-11 22:26:49 +0000 |
|---|---|---|
| committer | Linus Torvalds <[email protected]> | 2009-11-12 15:25:59 +0000 |
| commit | bcb3a1676b87effbdeffe8da5c44f63433d158d9 (patch) | |
| tree | 179eaa6692cad02a1e2b4c15a6919061aa06dd8d /fs/proc/array.c | |
| parent | rtc-vr41xx: fix do_div() warning (diff) | |
| download | kernel-bcb3a1676b87effbdeffe8da5c44f63433d158d9.tar.gz kernel-bcb3a1676b87effbdeffe8da5c44f63433d158d9.zip | |
rtc: v3020: fix v3020_mmio_read_bit()
v3020_mmio_read_bit() always returns 0 when left_shift > 7.
v3020_mmio_read_bit()'s return type is (unsigned char). The code returns
a value masked by (1 << left_shift) that is casted to the return type. If
left_shift is larger than 7, the cast will always result in a 0 return
value. The problem was discovered with left_shift = 16, and the included
patch corrects the problem.
The bug was introduced in the last (Apr 3 2009) commit of the file, kernel
versions 2.6.30 and later.
Cc: Alessandro Zummo <[email protected]>
Cc: Paul Gortmaker <[email protected]>
Cc: Raphael Assenat <[email protected]>
Cc: <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
Diffstat (limited to 'fs/proc/array.c')
0 files changed, 0 insertions, 0 deletions