diff options
| author | Bryan Donlan <[email protected]> | 2009-04-02 23:57:15 +0000 |
|---|---|---|
| committer | Linus Torvalds <[email protected]> | 2009-04-03 02:04:52 +0000 |
| commit | de18f3b2d68c1f3481839be760a5ff93f6a9a5e5 (patch) | |
| tree | 75b4b389baed2c56b1fc94948d1ab42e08ddcdfe /fs/hppfs/hppfs.c | |
| parent | ext3: use unsigned instead of int for type of blocksize in fs/ext3/namei.c (diff) | |
| download | kernel-de18f3b2d68c1f3481839be760a5ff93f6a9a5e5.tar.gz kernel-de18f3b2d68c1f3481839be760a5ff93f6a9a5e5.zip | |
ext3: return -EIO not -ESTALE on directory traversal through deleted inode
ext3_iget() returns -ESTALE if invoked on a deleted inode, in order to
report errors to NFS properly. However, in ext[234]_lookup(), this
-ESTALE can be propagated to userspace if the filesystem is corrupted such
that a directory entry references a deleted inode. This leads to a
misleading error message - "Stale NFS file handle" - and confusion on the
part of the admin.
The bug can be easily reproduced by creating a new filesystem, making a
link to an unused inode using debugfs, then mounting and attempting to ls
-l said link.
This patch thus changes ext3_lookup to return -EIO if it receives -ESTALE
from ext3_iget(), as ext3 does for other filesystem metadata corruption;
and also invokes the appropriate ext*_error functions when this case is
detected.
Signed-off-by: Bryan Donlan <[email protected]>
Cc: <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
Diffstat (limited to 'fs/hppfs/hppfs.c')
0 files changed, 0 insertions, 0 deletions
