diff options
| author | Julia Lawall <[email protected]> | 2016-10-29 19:36:55 +0000 |
|---|---|---|
| committer | Greg Kroah-Hartman <[email protected]> | 2016-11-07 09:19:49 +0000 |
| commit | 4d055647509402b0cfbd41cd69b3ce3a6b7c7efc (patch) | |
| tree | d9dd85643238f2a469697bde20cda868456848d1 /drivers/usb/class/cdc-acm.c | |
| parent | usbip: fix possibility of dereference by NULLL pointer in vhci_hcd.c (diff) | |
| download | kernel-4d055647509402b0cfbd41cd69b3ce3a6b7c7efc.tar.gz kernel-4d055647509402b0cfbd41cd69b3ce3a6b7c7efc.zip | |
wusbcore: dev-sysfs: use permission-specific DEVICE_ATTR variants
Use DEVICE_ATTR_WO for write ony attributes and DEVICE_ATTR_RO for read
only attributes. This simplifies the source code, improves readbility,
and reduces the chance of inconsistencies.
The semantic patch for the RO case is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@ro@
declarer name DEVICE_ATTR;
identifier x,x_show;
@@
DEVICE_ATTR(x, \(0444\|S_IRUGO\), x_show, NULL);
@script:ocaml@
x << ro.x;
x_show << ro.x_show;
@@
if not (x^"_show" = x_show) then Coccilib.include_match false
@@
declarer name DEVICE_ATTR_RO;
identifier ro.x,ro.x_show;
@@
- DEVICE_ATTR(x, \(0444\|S_IRUGO\), x_show, NULL);
+ DEVICE_ATTR_RO(x);
// </smpl>
Signed-off-by: Julia Lawall <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Diffstat (limited to 'drivers/usb/class/cdc-acm.c')
0 files changed, 0 insertions, 0 deletions