aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/usb/cdns3/cdns3-starfive.c
diff options
context:
space:
mode:
authorDan Williams <[email protected]>2023-10-31 21:09:19 +0000
committerDan Williams <[email protected]>2023-10-31 21:10:04 +0000
commit5d09c63f11f083707b60c8ea0bb420651c47740f (patch)
treed7709fb9c23eccf9a3b00bbf1bd3489e04afdf6a /drivers/usb/cdns3/cdns3-starfive.c
parentcxl/hdm: Fix && vs || bug (diff)
downloadkernel-5d09c63f11f083707b60c8ea0bb420651c47740f.tar.gz
kernel-5d09c63f11f083707b60c8ea0bb420651c47740f.zip
cxl/hdm: Remove broken error path
Dan reports that cxl_decoder_commit() potentially leaks a hold of cxl_dpa_rwsem. The potential error case is a "should not" happen scenario, turn it into a "can not" happen scenario by adding the error check to cxl_port_setup_targets() where other setting validation occurs. Reported-by: Dan Carpenter <[email protected]> Closes: http://lore.kernel.org/r/[email protected] Reviewed-by: Dave Jiang <[email protected]> Reviewed-by: Ira Weiny <[email protected]> Fixes: 176baefb2eb5 ("cxl/hdm: Commit decoder state to hardware") Signed-off-by: Dan Williams <[email protected]>
Diffstat (limited to 'drivers/usb/cdns3/cdns3-starfive.c')
0 files changed, 0 insertions, 0 deletions