diff options
| author | Dan Williams <[email protected]> | 2011-11-28 20:08:22 +0000 |
|---|---|---|
| committer | James Bottomley <[email protected]> | 2012-02-19 19:58:38 +0000 |
| commit | 3dff5721e4f67e6231dfc419d30aaa7563bfffd4 (patch) | |
| tree | 752102ef79f985f4d153b4791461404f67cdf467 /drivers/scsi/libsas/sas_init.c | |
| parent | [SCSI] libsas: kill invocation of scsi_eh_finish_cmd from sas_ata_task_done (diff) | |
| download | kernel-3dff5721e4f67e6231dfc419d30aaa7563bfffd4.tar.gz kernel-3dff5721e4f67e6231dfc419d30aaa7563bfffd4.zip | |
[SCSI] libsas: close error handling vs sas_ata_task_done() race
Since sas_ata does not implement ->freeze(), completions for scmds and
internal commands can still arrive concurrent with
ata_scsi_cmd_error_handler() and sas_ata_post_internal() respectively.
By the time either of those is called libata has committed to completing
the qc, and the ATA_PFLAG_FROZEN flag tells sas_ata_task_done() it has
lost the race.
In the sas_ata_post_internal() case we take on the additional
responsibility of freeing the sas_task to close the race with
sas_ata_task_done() freeing the the task while sas_ata_post_internal()
is in the process of invoking ->lldd_abort_task().
Signed-off-by: Dan Williams <[email protected]>
Signed-off-by: James Bottomley <[email protected]>
Diffstat (limited to 'drivers/scsi/libsas/sas_init.c')
0 files changed, 0 insertions, 0 deletions