diff options
| author | John Garry <[email protected]> | 2021-01-18 10:09:38 +0000 |
|---|---|---|
| committer | Martin K. Petersen <[email protected]> | 2021-01-23 02:31:07 +0000 |
| commit | 121181f3f839c29d8dd9fdc3cc9babbdc74227f8 (patch) | |
| tree | 6b617c5f2f03c0b57a7d6bd1aad9f03b1747aa1d /drivers/scsi/libsas/sas_init.c | |
| parent | scsi: libsas: docs: Remove notify_ha_event() (diff) | |
| download | kernel-121181f3f839c29d8dd9fdc3cc9babbdc74227f8.tar.gz kernel-121181f3f839c29d8dd9fdc3cc9babbdc74227f8.zip | |
scsi: libsas: Remove notifier indirection
LLDDs report events to libsas with .notify_port_event and .notify_phy_event
callbacks.
These callbacks are fixed and so there is no reason why the functions
cannot be called directly, so do that.
This neatens the code slightly, makes it more obvious, and reduces function
pointer usage, which is generally a good thing. Downside is that there are
2x more symbol exports.
[[email protected]: Remove the now unused "sas_ha" local variables]
Link: https://lore.kernel.org/r/[email protected]
Reviewed-by: Christoph Hellwig <[email protected]>
Reviewed-by: Jack Wang <[email protected]>
Signed-off-by: John Garry <[email protected]>
Signed-off-by: Ahmed S. Darwish <[email protected]>
Signed-off-by: Martin K. Petersen <[email protected]>
Diffstat (limited to 'drivers/scsi/libsas/sas_init.c')
| -rw-r--r-- | drivers/scsi/libsas/sas_init.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/drivers/scsi/libsas/sas_init.c b/drivers/scsi/libsas/sas_init.c index 21c43b18d5d5..6dc2505d36af 100644 --- a/drivers/scsi/libsas/sas_init.c +++ b/drivers/scsi/libsas/sas_init.c @@ -123,12 +123,6 @@ int sas_register_ha(struct sas_ha_struct *sas_ha) goto Undo_phys; } - error = sas_init_events(sas_ha); - if (error) { - pr_notice("couldn't start event thread:%d\n", error); - goto Undo_ports; - } - error = -ENOMEM; snprintf(name, sizeof(name), "%s_event_q", dev_name(sas_ha->dev)); sas_ha->event_q = create_singlethread_workqueue(name); |