aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/platform/x86/intel/pmt/class.c
diff options
context:
space:
mode:
authorDavid Lechner <[email protected]>2025-01-15 20:48:27 +0000
committerGuenter Roeck <[email protected]>2025-01-15 21:52:43 +0000
commite9b24deb84863c5a77dda5be57b6cb5bf4127b85 (patch)
tree277b2929d70d20a7ec5b9463f7bfb7fcf885f6e6 /drivers/platform/x86/intel/pmt/class.c
parenthwmon: (drivetemp) Set scsi command timeout to 10s (diff)
downloadkernel-e9b24deb84863c5a77dda5be57b6cb5bf4127b85.tar.gz
kernel-e9b24deb84863c5a77dda5be57b6cb5bf4127b85.zip
hwmon: (ltc2991) Fix mixed signed/unsigned in DIV_ROUND_CLOSEST
Fix use of DIV_ROUND_CLOSEST where a possibly negative value is divided by an unsigned type by casting the unsigned type to the signed type of the same size (st->r_sense_uohm[channel] has type of u32). The docs on the DIV_ROUND_CLOSEST macro explain that dividing a negative value by an unsigned type is undefined behavior. The actual behavior is that it converts both values to unsigned before doing the division, for example: int ret = DIV_ROUND_CLOSEST(-100, 3U); results in ret == 1431655732 instead of -33. Fixes: 2b9ea4262ae9 ("hwmon: Add driver for ltc2991") Signed-off-by: David Lechner <[email protected]> Link: https://lore.kernel.org/r/20250115-hwmon-ltc2991-fix-div-round-closest-v1-1-b4929667e457@baylibre.com Signed-off-by: Guenter Roeck <[email protected]>
Diffstat (limited to 'drivers/platform/x86/intel/pmt/class.c')
0 files changed, 0 insertions, 0 deletions