aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/platform/x86/intel/int3472/led.c
diff options
context:
space:
mode:
authorHans de Goede <[email protected]>2023-10-04 16:23:16 +0000
committerIlpo Järvinen <[email protected]>2023-10-06 10:34:58 +0000
commit5ccf9873ab2bcb7c480bc2ccea55ec235d9db175 (patch)
tree537b99bfecb4ae9eabf0f267ce39bd11c636c0f9 /drivers/platform/x86/intel/int3472/led.c
parentplatform/x86: int3472: Stop using gpiod_toggle_active_low() (diff)
downloadkernel-5ccf9873ab2bcb7c480bc2ccea55ec235d9db175.tar.gz
kernel-5ccf9873ab2bcb7c480bc2ccea55ec235d9db175.zip
platform/x86: int3472: Switch to devm_get_gpiod()
Switch to devm_get_gpiod() for discrete GPIOs for clks / regulators / LEDs and let devm do the cleanup for us. Reviewed-by: Andy Shevchenko <[email protected]> Signed-off-by: Hans de Goede <[email protected]> Reviewed-by: Bartosz Golaszewski <[email protected]> Link: https://lore.kernel.org/r/[email protected] Reviewed-by: Ilpo Järvinen <[email protected]> Signed-off-by: Ilpo Järvinen <[email protected]>
Diffstat (limited to 'drivers/platform/x86/intel/int3472/led.c')
-rw-r--r--drivers/platform/x86/intel/int3472/led.c7
1 files changed, 1 insertions, 6 deletions
diff --git a/drivers/platform/x86/intel/int3472/led.c b/drivers/platform/x86/intel/int3472/led.c
index 476cd637fc51..9cbed694e2ca 100644
--- a/drivers/platform/x86/intel/int3472/led.c
+++ b/drivers/platform/x86/intel/int3472/led.c
@@ -39,7 +39,7 @@ int skl_int3472_register_pled(struct int3472_discrete_device *int3472, struct gp
ret = led_classdev_register(int3472->dev, &int3472->pled.classdev);
if (ret)
- goto err_free_gpio;
+ return ret;
int3472->pled.lookup.provider = int3472->pled.name;
int3472->pled.lookup.dev_id = int3472->sensor_name;
@@ -47,10 +47,6 @@ int skl_int3472_register_pled(struct int3472_discrete_device *int3472, struct gp
led_add_lookup(&int3472->pled.lookup);
return 0;
-
-err_free_gpio:
- gpiod_put(int3472->pled.gpio);
- return ret;
}
void skl_int3472_unregister_pled(struct int3472_discrete_device *int3472)
@@ -60,5 +56,4 @@ void skl_int3472_unregister_pled(struct int3472_discrete_device *int3472)
led_remove_lookup(&int3472->pled.lookup);
led_classdev_unregister(&int3472->pled.classdev);
- gpiod_put(int3472->pled.gpio);
}