diff options
| author | Ryo Takakura <[email protected]> | 2025-02-18 08:08:30 +0000 |
|---|---|---|
| committer | Bjorn Helgaas <[email protected]> | 2025-03-19 01:05:06 +0000 |
| commit | 18056a48669a040bef491e63b25896561ee14d90 (patch) | |
| tree | fc38650e70a1aac99076dee544f9283afa88685c /drivers/pci/controller/dwc/pcie-qcom-ep.c | |
| parent | Linux 6.14-rc1 (diff) | |
| download | kernel-18056a48669a040bef491e63b25896561ee14d90.tar.gz kernel-18056a48669a040bef491e63b25896561ee14d90.zip | |
PCI: vmd: Make vmd_dev::cfg_lock a raw_spinlock_t type
The access to the PCI config space via pci_ops::read and pci_ops::write is
a low-level hardware access. The functions can be accessed with disabled
interrupts even on PREEMPT_RT. The pci_lock is a raw_spinlock_t for this
purpose.
A spinlock_t becomes a sleeping lock on PREEMPT_RT, so it cannot be
acquired with disabled interrupts. The vmd_dev::cfg_lock is accessed in
the same context as the pci_lock.
Make vmd_dev::cfg_lock a raw_spinlock_t type so it can be used with
interrupts disabled.
This was reported as:
BUG: sleeping function called from invalid context at kernel/locking/spinlock_rt.c:48
Call Trace:
rt_spin_lock+0x4e/0x130
vmd_pci_read+0x8d/0x100 [vmd]
pci_user_read_config_byte+0x6f/0xe0
pci_read_config+0xfe/0x290
sysfs_kf_bin_read+0x68/0x90
Signed-off-by: Ryo Takakura <[email protected]>
Tested-by: Luis Claudio R. Goncalves <[email protected]>
Acked-by: Luis Claudio R. Goncalves <[email protected]>
[bigeasy: reword commit message]
Signed-off-by: Sebastian Andrzej Siewior <[email protected]>
Tested-off-by: Luis Claudio R. Goncalves <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
[kwilczynski: commit log]
Signed-off-by: Krzysztof WilczyĆski <[email protected]>
[bhelgaas: add back report info from
https://lore.kernel.org/lkml/[email protected]/]
Signed-off-by: Bjorn Helgaas <[email protected]>
Diffstat (limited to 'drivers/pci/controller/dwc/pcie-qcom-ep.c')
0 files changed, 0 insertions, 0 deletions
