diff options
| author | Ilpo Järvinen <[email protected]> | 2025-05-05 11:54:12 +0000 |
|---|---|---|
| committer | Bjorn Helgaas <[email protected]> | 2025-05-05 18:39:59 +0000 |
| commit | f3efb9569b4a21354ef2caf7ab0608a3e14cc6e4 (patch) | |
| tree | fb9ad64d821c1cc2df1bbe5665d604a3f729f4fd /drivers/pci/controller/dwc/pcie-qcom-common.c | |
| parent | Linux 6.15-rc1 (diff) | |
| download | kernel-f3efb9569b4a21354ef2caf7ab0608a3e14cc6e4.tar.gz kernel-f3efb9569b4a21354ef2caf7ab0608a3e14cc6e4.zip | |
PCI: Fix lock symmetry in pci_slot_unlock()
The commit a4e772898f8b ("PCI: Add missing bridge lock to pci_bus_lock()")
made the lock function to call depend on dev->subordinate but left
pci_slot_unlock() unmodified creating locking asymmetry compared with
pci_slot_lock().
Because of the asymmetric lock handling, the same bridge device is unlocked
twice. First pci_bus_unlock() unlocks bus->self and then pci_slot_unlock()
will unconditionally unlock the same bridge device.
Move pci_dev_unlock() inside an else branch to match the logic in
pci_slot_lock().
Fixes: a4e772898f8b ("PCI: Add missing bridge lock to pci_bus_lock()")
Signed-off-by: Ilpo Järvinen <[email protected]>
Signed-off-by: Bjorn Helgaas <[email protected]>
Reviewed-by: Lukas Wunner <[email protected]>
Reviewed-by: Dave Jiang <[email protected]>
Cc: [email protected]
Link: https://patch.msgid.link/[email protected]
Diffstat (limited to 'drivers/pci/controller/dwc/pcie-qcom-common.c')
0 files changed, 0 insertions, 0 deletions
