aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/ethernet/intel/igb/igb_main.c
diff options
context:
space:
mode:
authorSerhey Popovych <[email protected]>2018-03-29 14:51:36 +0000
committerJeff Kirsher <[email protected]>2019-03-19 21:18:49 +0000
commitb0ddfe2bb2bd80b1090d5bf42bb65243b76d3b97 (patch)
tree6e490599d6b3e29b1f85331441b98a0be734e8ea /drivers/net/ethernet/intel/igb/igb_main.c
parentvirtio_net: remove hcpu from virtnet_clean_affinity (diff)
downloadkernel-b0ddfe2bb2bd80b1090d5bf42bb65243b76d3b97.tar.gz
kernel-b0ddfe2bb2bd80b1090d5bf42bb65243b76d3b97.zip
intel: correct return from set features callback
According to comments in <linux/netdevice.h> we should return either >0 or -errno from ->ndo_set_features() if changing dev->features by itself. Return 1 in such places to notify netdev_update_features() about applied changes in dev->features. Signed-off-by: Serhey Popovych <[email protected]> Tested-by: Aaron Brown <[email protected]> Signed-off-by: Jeff Kirsher <[email protected]>
Diffstat (limited to 'drivers/net/ethernet/intel/igb/igb_main.c')
-rw-r--r--drivers/net/ethernet/intel/igb/igb_main.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
index 69b230c53fed..45f3c19d063a 100644
--- a/drivers/net/ethernet/intel/igb/igb_main.c
+++ b/drivers/net/ethernet/intel/igb/igb_main.c
@@ -2480,7 +2480,7 @@ static int igb_set_features(struct net_device *netdev,
else
igb_reset(adapter);
- return 0;
+ return 1;
}
static int igb_ndo_fdb_add(struct ndmsg *ndm, struct nlattr *tb[],