diff options
| author | Paolo Abeni <[email protected]> | 2024-09-03 08:43:50 +0000 |
|---|---|---|
| committer | Paolo Abeni <[email protected]> | 2024-09-03 08:43:50 +0000 |
| commit | c2eb0626536f49f25e544d9d178c047b544340bb (patch) | |
| tree | f6ff3809df5aa784aa860caa2c42eac3ca497aba /drivers/net/ethernet/intel/ice/ice_lib.c | |
| parent | Merge tag 'for-net-2024-08-30' of git://git.kernel.org/pub/scm/linux/kernel/g... (diff) | |
| parent | net: ethernet: ti: am65-cpsw: Fix RX statistics for XDP_TX and XDP_REDIRECT (diff) | |
| download | kernel-c2eb0626536f49f25e544d9d178c047b544340bb.tar.gz kernel-c2eb0626536f49f25e544d9d178c047b544340bb.zip | |
Merge branch 'net-ethernet-ti-am65-cpsw-fix-xdp-implementation'
Roger Quadros says:
====================
net: ethernet: ti: am65-cpsw: Fix XDP implementation
The XDP implementation on am65-cpsw driver is broken in many ways
and this series fixes it.
Below are the current issues that are being fixed:
1) The following XDP_DROP test from [1] stalls the interface after
250 packets.
~# xdb-bench drop -m native eth0
This is because new RX requests are never queued. Fix that.
2) The below XDP_TX test from [1] fails with a warning
[ 499.947381] XDP_WARN: xdp_update_frame_from_buff(line:277): Driver BUG: missing reserved tailroom
~# xdb-bench tx -m native eth0
Fix that by using PAGE_SIZE during xdp_init_buf().
3) In XDP_REDIRECT case only 1 packet was processed in rx_poll.
Fix it to process up to budget packets.
~# ./xdp-bench redirect -m native eth0 eth0
4) If number of TX queues are set to 1 we get a NULL pointer
dereference during XDP_TX.
~# ethtool -L eth0 tx 1
~# ./xdp-trafficgen udp -A <ipv6-src> -a <ipv6-dst> eth0 -t 2
Transmitting on eth0 (ifindex 2)
[ 241.135257] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000030
5) Net statistics is broken for XDP_TX and XDP_REDIRECT
[1] xdp-tools suite https://github.com/xdp-project/xdp-tools
Signed-off-by: Roger Quadros <[email protected]>
Reviewed-by: Jacob Keller <[email protected]>
Acked-by: Julien Panis <[email protected]>
Reviewed-by: MD Danish Anwar <[email protected]>
---
====================
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Paolo Abeni <[email protected]>
Diffstat (limited to 'drivers/net/ethernet/intel/ice/ice_lib.c')
0 files changed, 0 insertions, 0 deletions
